[cancun] [eip6780] apply danno's clarification: disable eth burn on preexisting contract when inheritor equals contract address #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
approved these changes
Aug 17, 2023
Demuirgos
approved these changes
Aug 17, 2023
smartprogrammer93
deleted the
fix/apply_6780_clarification_no_burn_with_pre_existing
branch
Comment on lines
+2369
to
2373
| if (spec.SelfdestructOnlyOnSameTransaction && !createInSameTx && inheritor.Equals(executingAccount)) | ||
| return true; // dont burn eth when contract is not destroyed per EIP clarification | ||
|
|
||
| _state.SubtractFromBalance(executingAccount, result, spec); | ||
| return true; |
There was a problem hiding this comment.
Wouldn't:
if (!spec.SelfdestructOnlyOnSameTransaction || createInSameTx || !inheritor.Equals(executingAccount))
{
_state.SubtractFromBalance(executingAccount, result, spec);
}
return true;
be more readable?
There was a problem hiding this comment.
I like to specify only the condition where the burn does not happen. I find it less confusing than specifying all the conditions that it does burn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context here:
ethereum/EIPs#7308
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes