Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JsonRPC][Optimization]Duplicate calls to FindHeader in eth_getLogs #6410

Closed
smartprogrammer93 opened this issue Dec 22, 2023 · 0 comments · Fixed by #6421
Closed

[JsonRPC][Optimization]Duplicate calls to FindHeader in eth_getLogs #6410

smartprogrammer93 opened this issue Dec 22, 2023 · 0 comments · Fixed by #6421

Comments

@smartprogrammer93
Copy link
Contributor

in eth_getLogs we call SearchForHeader which calls FindHeader for fromBlock and toBlock, then we callFindHeader in the LogFinder.FindLogs for the same blocks again.
@smartprogrammer93 smartprogrammer93 changed the title {JsonRPC]{Optimization}Duplicate calls to FindHeader in eth_getLogs {JsonRPC][Optimization]Duplicate calls to FindHeader in eth_getLogs Dec 22, 2023
@smartprogrammer93 smartprogrammer93 changed the title {JsonRPC][Optimization]Duplicate calls to FindHeader in eth_getLogs [JsonRPC][Optimization]Duplicate calls to FindHeader in eth_getLogs Dec 22, 2023
@benaadams benaadams mentioned this issue Dec 26, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate calls to FindHeader in eth_getLogs NethermindEth/nethermind
1 participant
@smartprogrammer93