Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JsonRPC][Optimization]Duplicate call to TryGetPendingTransaction in RPC #6375

Closed
smartprogrammer93 opened this issue Dec 14, 2023 · 0 comments · Fixed by #6420
Closed

[JsonRPC][Optimization]Duplicate call to TryGetPendingTransaction in RPC #6375

smartprogrammer93 opened this issue Dec 14, 2023 · 0 comments · Fixed by #6420

Comments

@smartprogrammer93
Copy link
Contributor

In eth_getTransactionByHash we first call TryGetPendingTransaction as shown:
image
then we call it again in the _blockchainBridge.GetTransaction as in here:
image
@smartprogrammer93 smartprogrammer93 changed the title Duplicate call to TryGetPendingTransaction in RPC [JsonRPC][Optimization]Duplicate call to TryGetPendingTransaction in RPC Dec 22, 2023
@benaadams benaadams mentioned this issue Dec 26, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Duplicate call to TryGetPendingTransaction in RPC NethermindEth/nethermind
1 participant
@smartprogrammer93