Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EVM to use error codes instead of exceptions for byte code processing. #63

Closed
tkstanczak opened this issue Aug 16, 2018 · 1 comment
Closed

Refactor EVM to use error codes instead of exceptions for byte code processing. #63

tkstanczak opened this issue Aug 16, 2018 · 1 comment
Labels
difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. a

Comments

@tkstanczak
Copy link
Member

We have already done it for most of the cases but still have a few where we actually throw exceptions (e.g. overflow, underflow).
We want to only use exception for client failures. EVM exceptions should be error codes / included in execution status.
@tkstanczak tkstanczak self-assigned this Oct 7, 2018
@tkstanczak tkstanczak added the difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. a label Feb 1, 2019
@tkstanczak tkstanczak removed their assignment Feb 7, 2021
@benaadams
Copy link
Member

Resolved by #6425, #6406, #5727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. a
Projects
Nethermind Core
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkstanczak @benaadams