Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniil/rewrite-functional-iterators-into-for-loop-statement #1954

Merged
merged 16 commits into from
Aug 19, 2024
Merged

Daniil/rewrite-functional-iterators-into-for-loop-statement #1954

merged 16 commits into from
Aug 19, 2024

Conversation

AnkushinDaniil
Copy link
Contributor

fixes #1952

kirugan
kirugan reviewed Jul 16, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
kirugan
kirugan reviewed Jul 16, 2024
View reviewed changes
p2p/sync.go Outdated Show resolved Hide resolved
@kirugan kirugan force-pushed the daniil/rewrite-functional-iterators-into-for-loop-statement branch from 498843a to e493941 Compare July 17, 2024 09:21
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (50bc46d) to head (b495f8b).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   78.18%   78.21%   +0.02%     
==========================================
  Files         101      100       -1     
  Lines        9062     9046      -16     
==========================================
- Hits         7085     7075      -10     
+ Misses       1345     1342       -3     
+ Partials      632      629       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

derrix060
derrix060 previously requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@derrix060 derrix060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing on lint

@AnkushinDaniil
Copy link
Contributor Author

Currently golangci-lint does not support GOEXPERIMENT=rangefunc, we have to wait for an update.

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/rewrite-functional-iterators-into-for-loop-statement branch 2 times, most recently from 9830289 to 28b4dd1 Compare August 19, 2024 11:44
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/rewrite-functional-iterators-into-for-loop-statement branch 3 times, most recently from c525132 to a355703 Compare August 19, 2024 13:23
@AnkushinDaniil
GOEXPERIMENT=rangefunc added
3151b65
@AnkushinDaniil
headersIt refactoring
72f6e85
@AnkushinDaniil
genHeadersAndSigs refactored with label and break
1962a58
@AnkushinDaniil
genEvents refactored, eventsIt rewritten into for loop statement
9eb694c
@AnkushinDaniil
genClasses refactored, classesIt rewritten into for loop statement
1c62891
@AnkushinDaniil
select fixed
a594268
@AnkushinDaniil
select unfixed
73425c9
@AnkushinDaniil
genStateDiffs refactored, stateDiffsIt rewritten into for loop statement
8a31cf4
@AnkushinDaniil
genTransactions refactored, txsIt rewritten into for loop statement
d8035da
@AnkushinDaniil
added TODO remove "export GOEXPERIMENT=rangefunc" after updating to G…
74c4b45 
…o 1.23
@AnkushinDaniil
label deleted
cf58e8c
@AnkushinDaniil
updated comment
25d7528
@AnkushinDaniil
Remove export GOEXPERIMENT=rangefunc due to go 1.23 release
9d199f2
@AnkushinDaniil
Remove unused iter package and related tests due to go 1.23.0 release
963c8b9
@AnkushinDaniil
Update import iter package
a574190
@AnkushinDaniil
Add a nolint comment until the gci issue is fixed
b495f8b
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/rewrite-functional-iterators-into-for-loop-statement branch from a355703 to b495f8b Compare August 19, 2024 14:03
@derrix060 derrix060 dismissed their stale review August 19, 2024 14:22

not anymore

@kirugan kirugan merged commit 0ac7e87 into NethermindEth:main Aug 19, 2024
8 checks passed
@AnkushinDaniil AnkushinDaniil deleted the daniil/rewrite-functional-iterators-into-for-loop-statement branch August 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirugan kirugan kirugan approved these changes

@IronGauntlets IronGauntlets IronGauntlets approved these changes

@derrix060 derrix060 Awaiting requested review from derrix060

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite functional iterators into for loop statement
4 participants
@AnkushinDaniil @kirugan @derrix060 @IronGauntlets