Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Slack Ephemeral Messages #63

Merged
merged 1 commit into from
Oct 29, 2017

Conversation

viveksyngh
Copy link
Contributor

@viveksyngh viveksyngh commented Oct 14, 2017

Added support for ephemeral messages in below slack_comm functions

say
send_*

#56

@viveksyngh viveksyngh changed the title added Slack Ephemeral Messages support in say and all send_ functions Support Slack Ephemeral Messages Oct 14, 2017
@mikegrima
Copy link
Contributor

I will look into merging this within the next week or so.

@mikegrima
Copy link
Contributor

Code looks good. Will need to test locally and will then merge.

Thank you so much for working on this @viveksyngh !

@mikegrima mikegrima mentioned this pull request Oct 23, 2017
@mikegrima
Copy link
Contributor

Testing this today

@mikegrima
Copy link
Contributor

It works! Thank you so much for working on this! :)

@mikegrima mikegrima merged commit 887d498 into Netflix:develop Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants