Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding decorators for parsing commands. #40

Merged
merged 3 commits into from
Jun 6, 2017
Merged

Adding decorators for parsing commands. #40

merged 3 commits into from
Jun 6, 2017

Conversation

mikegrima
Copy link
Contributor

@mikegrima mikegrima commented May 7, 2017 •
edited
Loading

  • Significant refactor
  • Adds a lot of niceties and removes need for copypasta

@mikegrima mikegrima self-assigned this May 7, 2017
@mikegrima mikegrima mentioned this pull request May 7, 2017
Closed
@mikegrima mikegrima mentioned this pull request May 14, 2017
Closed
@jrm16020 jrm16020 mentioned this pull request May 21, 2017
Closed
Adding decorators for parsing commands.
b8b139d 
- Significant refactor
- Adds a lot of niceties and removes need for copypasta
@mikegrima
Copy link
Contributor Author

mikegrima commented May 23, 2017 •
edited
Loading

Added an @auth() decorator which is to be used in conjunction with the @hubcommander_command() decorator.

This should mostly be stable, but I would like to convert some GitHub commands over before merging.

@mikegrima mikegrima mentioned this pull request May 28, 2017
Closed
@mikegrima
Copy link
Contributor Author

Added some more decorators in, such as:

  • @github_user_exists
  • @repo_must_exist

and currently converting all of the GitHub commands over to the new decorated model.

The new decorators also have the ability of specifying if an argument should be all lowercase, uppercase, or case-sensitive.

@mikegrima mikegrima mentioned this pull request May 28, 2017
Closed
@mikegrima
Copy link
Contributor Author

Added a new decorator @branch_must_exist

New Decorators added and refactoring.
3e22b56 
Converted the GitHub commands:
- !SetDescription
- !SetHomepage
- !AddCollab
- !AddUserToTeam
- !CreateRepo
- !DeleteRepo
- !SetDefaultBranch
- !SetBranchProtection
- !ListPRs
- !ListKeys
- !AddKey
- !DeleteKey
- !GetKey
@mikegrima
Copy link
Contributor Author

Updated the documentation. Will need to do some more testing before merging.

@mikegrima mikegrima changed the title [WIP] Adding decorators for parsing commands. Adding decorators for parsing commands. Jun 6, 2017
@mikegrima mikegrima merged commit 1cd11c9 into Netflix:develop Jun 6, 2017
@mikegrima mikegrima deleted the decorators branch June 6, 2017 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbengtson willbengtson Awaiting requested review from willbengtson

Assignees

@mikegrima mikegrima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikegrima