Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the github plugin dependency to start bot #35

Merged
merged 5 commits into from
May 16, 2017

Conversation

goduncan
Copy link
Contributor

  • This change moves the github plugin to the command_plugin directory allowing the bot to be run with only a Slack Token.
  • Idea is to use hubcommander as generic python Slack bot framework for people to build on.

@mikegrima
Copy link
Contributor

I'll try to take a look at this later this week.

@mikegrima
Copy link
Contributor

mikegrima commented Apr 25, 2017

I'll need to see how this works with regards to plugins that make use of GitHub.

For example, I'll need to see how the Travis CI plugin would work with this change.

@goduncan goduncan changed the title [WIP] Remove the github plugin dependency to start bot Remove the github plugin dependency to start bot Apr 29, 2017
@mikegrima
Copy link
Contributor

@goduncan : Been busy lately -- didn't forget about this. Can you resolve the conflicts?

@goduncan
Copy link
Contributor Author

goduncan commented May 2, 2017

No worries. I haven't had time to test if the Travis plugin works as before with the changed but the bot starts with it enabled.

@goduncan
Copy link
Contributor Author

Hello. Do you still think it's likely that you will be merge this?

@mikegrima
Copy link
Contributor

Hi @goduncan ! I will look at it today. I PROMISE!

@mikegrima
Copy link
Contributor

mikegrima commented May 16, 2017

You will need to make a change here: https://github.com/goduncan/hubcommander/blob/develop/command_plugins/travis_ci/plugin.py#L72

GitHub is a dependency for Travis CI.

I'll come up with the sample fix.

@mikegrima
Copy link
Contributor

@goduncan The PR looks good.

I will submit a follow-up PR with the additional fixes for Travis CI.

@mikegrima mikegrima merged commit 9b8a7e0 into Netflix:develop May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants