Feature/centralize dependencies in root #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sync-packages-deps.js script ISSUES CLOSED: NationalBankBelgium#2695
BREAKING CHANGE:
Due to TSLint update, it is required to adapt the usage in "tslint.json" file at the root of the project:
```txt
// Before
{
"extends": [
// ...
"@nationalbankbelgium/code-style/tslint/5.20.x",
// ...
]
// ...
}
// After
{
"extends": [
// ...
"@nationalbankbelgium/code-style/tslint/6.1.x",
// ...
]
// ...
}
SuperITMan
added
comp: build-main
|
Kudos, SonarCloud Quality Gate passed!
|
|
A demo of Dependabot PR can be found on my fork: SuperITMan#1151 |
nicanac
approved these changes
May 25, 2021
SuperITMan
added a commit
to SuperITMan/stark
that referenced
this pull request
Sep 2, 2021
RELATED ISSUE: NationalBankBelgium#2696 RELATED PR: NationalBankBelgium#2746
3 tasks
SuperITMan
added a commit
to SuperITMan/stark
that referenced
this pull request
Sep 2, 2021
RELATED ISSUE: NationalBankBelgium#2696 RELATED PR: NationalBankBelgium#2746
SuperITMan
added a commit
to SuperITMan/stark
that referenced
this pull request
Sep 2, 2021
RELATED ISSUE: NationalBankBelgium#2696 RELATED PR: NationalBankBelgium#2746
SuperITMan
added a commit
to SuperITMan/stark
that referenced
this pull request
Sep 2, 2021
RELATED ISSUE: NationalBankBelgium#2696 RELATED PR: NationalBankBelgium#2746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Dependencies are duplicated in root folder and in stark packages folders.
Moreover, some dependencies are not in sync between packages.
Due to NodeJS behavior, dependencies installed in root are available in showcase and in starter.
This can have side effects.
TSLint is not up to date in stark-build dependencies.
Issue Number: #2695
What is the new behavior?
All the dependencies are installed only in root folder. When a PR is introduced, the build checks if devDependencies versions in root "package.json" are in sync with dependencies version in stark packages.
If this is not the case, the build will fail. If the PR has been created by Dependabot, another workflow will be triggered and will update dependencies version in stark packages. After that, the workflow, thanks to the newcomer @nbb-bot 🤖, will push new commits to the Dependabot branch and will add a comment to the PR to mention that new commits have been added to the branch. This will trigger the "build" workflow that should work this time 👍
To solve the potential issue due to root dependencies available in showcase and starter, I refactored the build workflow to remove root dependencies before installing and running tests in showcase and starter.
Moreover, for Dependabot PRs, I adapted the build to remove the "package-lock.json" file in showcase to ensure it installs the right dependencies after updating stark-* dependencies.
TSLint is updated to v6.1 in stark-build dependencies.
Does this PR introduce a breaking change?
Other information