Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of Tag model and schema is misleading (and incorrect) #32

Open
NamesJ opened this issue Mar 7, 2021 · 0 comments
Open

Definition of Tag model and schema is misleading (and incorrect) #32

NamesJ opened this issue Mar 7, 2021 · 0 comments
Labels
invalid This doesn't seem right
Milestone

Comments

@NamesJ
Copy link
Owner

NamesJ commented Mar 7, 2021

Currently, the Tag schema is ('entity_type', 'entity_value', 'tag').
Example data: {'entity_type': 'User.username', 'entity_value: 'ClaustrophobicSkeleton', 'tag': 'baked goods'}.

This works, but entity_type being set as a field for a specific schema seems incorrect and potentially confusing. Ditto for having a tag field in the Tag schema.

A more appropriate schema for Tag would be ('entity_type', 'field_type, 'field_value', 'tag_value').
Example data: {'entity_type': 'User', 'field_type': 'username', 'field_value': 'ClaustrophobicSkeleton', 'tag_value': 'baked goods'}

@NamesJ NamesJ added the invalid This doesn't seem right label Mar 7, 2021
@NamesJ NamesJ added this to the Beta milestone Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant