Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shrec dataset #375

Merged
merged 13 commits into from
Jun 18, 2021
Merged

Conversation

JerryJiehanWang
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Caenorst Caenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little comment for documenting the return type

`here <https://shapenet.cs.stanford.edu/shrec16/>`_.

The `__getitem__` method will return a `KaolinDatasetItem`, with its `data`
field containing a `kaolin.io.obj.return_type`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer something like "with its data field containing a namedtuple returned by :func:kaolin.io.obj.import_mesh" since kaolin.io.obj.return_type is not documented.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detailed description added.

f"Valid categories are {VALID_CATEGORIES}"
)

clsdir = os.path.join(root, category, "train" if train else "test")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there is an issue related to this structure for SHREC16: #277
Can you address that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I download the dataset from the official website: http://shapenet.cs.stanford.edu/shrec16/ and it seems to be orgainzed in "test" "train" and "val" set. I'm waiting for their reply to see which website did they download the shrec16 dataset.

kaolin/io/shrec.py Show resolved Hide resolved
'04468005': 'train',
'04530566': 'vessel',
'04554684': 'washer',
'04591713': 'wine bottle'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'wine bottle' doesn't seem to be a valid category

Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
from kaolin.io.obj import return_type
from kaolin.io.shrec import SHREC16

SHREC16_PATH = '/home/jiehanw/Downloads/shrec16'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's your personal path, I recommend /data/shrec16/

Signed-off-by: Jiehan Wang <jiehanw@nvidia.com>
Signed-off-by: Jiehan Wang <jiehanw@nvidia.com>
Copy link
Collaborator

@Caenorst Caenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Caenorst Caenorst merged commit e5bc871 into NVIDIAGameWorks:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants