-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shrec dataset #375
Adding shrec dataset #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a little comment for documenting the return type
`here <https://shapenet.cs.stanford.edu/shrec16/>`_. | ||
|
||
The `__getitem__` method will return a `KaolinDatasetItem`, with its `data` | ||
field containing a `kaolin.io.obj.return_type`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer something like "with its data
field containing a namedtuple returned by :func:kaolin.io.obj.import_mesh
" since kaolin.io.obj.return_type
is not documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detailed description added.
6200f0e
to
2135ad2
Compare
kaolin/io/shrec.py
Outdated
f"Valid categories are {VALID_CATEGORIES}" | ||
) | ||
|
||
clsdir = os.path.join(root, category, "train" if train else "test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there is an issue related to this structure for SHREC16: #277
Can you address that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I download the dataset from the official website: http://shapenet.cs.stanford.edu/shrec16/ and it seems to be orgainzed in "test" "train" and "val" set. I'm waiting for their reply to see which website did they download the shrec16 dataset.
a7bc453
to
eab2a13
Compare
kaolin/io/shrec.py
Outdated
'04468005': 'train', | ||
'04530566': 'vessel', | ||
'04554684': 'washer', | ||
'04591713': 'wine bottle'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'wine bottle' doesn't seem to be a valid category
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
Signed-off-by: jiehanw <jiehanw@nvidia.com>
38389c1
to
0363288
Compare
Signed-off-by: jiehanw <jiehanw@nvidia.com>
tests/python/kaolin/io/test_shrec.py
Outdated
from kaolin.io.obj import return_type | ||
from kaolin.io.shrec import SHREC16 | ||
|
||
SHREC16_PATH = '/home/jiehanw/Downloads/shrec16' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's your personal path, I recommend /data/shrec16/
Signed-off-by: Jiehan Wang <jiehanw@nvidia.com>
Signed-off-by: Jiehan Wang <jiehanw@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
No description provided.