Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why needs double check in ncclIbIsend and ncclIbIrecv? #1375

Open
jiangxiaobin96 opened this issue Jul 26, 2024 · 0 comments
Open

Why needs double check in ncclIbIsend and ncclIbIrecv? #1375

jiangxiaobin96 opened this issue Jul 26, 2024 · 0 comments

Comments

@jiangxiaobin96
Copy link

Some codes not understand when studying source code.
comm->ready only set in connect and accept when init connecting . why here needs double check?

// ncclIbIsend
if (comm->ready == 0) { WARN("NET/IB: ncclIbIsend() called when comm->ready == 0"); return ncclInternalError; }
if (comm->ready == 0) { *request = NULL; return ncclSuccess; }
// ncclIbIrecv
if (comm->ready == 0) { WARN("NET/IB: ncclIbIrecv() called when comm->ready == 0"); return ncclInternalError; }
if (comm->ready == 0) { *request = NULL; return ncclSuccess; }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant