Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy Manager and NLG modules for MultiWOZ #691

Merged
merged 39 commits into from
Jun 5, 2020
Merged

Policy Manager and NLG modules for MultiWOZ #691

merged 39 commits into from
Jun 5, 2020

Conversation

ekmb
Copy link
Collaborator

@ekmb ekmb commented Jun 2, 2020

A rule-based policy manager and natural language generation modules added to complete the goal-oriented dialogue pipeline on MultiWOZ dataset.

The complete pipeline for Multiwoz looks like this:

User utterance => DST module (pre-trained TRADE) => rule-based PM => rule-based NLG => system reply
With the added example users can have a conversation with the system and analyze the results of each of the dialogue modules separately.

Signed-off-by: Evelina Bakhturina ebakhturina@nvidia.com

ekmb added 13 commits June 2, 2020 15:09
@ekmb
pm+nlg for multiwoz init
5639eeb 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
pipeline is working, init clean up
a3385fb 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
headers added
329402a 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
fixed invalid .json file, added db files to multiwoz preprocessing
e2460c6 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
code clean up
d2aaeda 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
lgtm fixes
90b885a 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
docs for TRADE update, jenkins for ruled_based example
4538da5 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
jenkins fix
aeb46a3 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
ports refactor wip
d899791 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
ports refactor wip
5ff2d2c 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
wip works
97c9dce 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
neural types refactored
7c943a0 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
remove unused
12256c9 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2020

This pull request introduces 23 alerts when merging a7b0ab5 into 78b6bef - view on LGTM.com

new alerts:

  • 15 for Unused import
  • 8 for Wrong name for an argument in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2020

This pull request introduces 23 alerts when merging 12256c9 into 78b6bef - view on LGTM.com

new alerts:

  • 15 for Unused import
  • 8 for Wrong name for an argument in a class instantiation

@ekmb
lgtm fixes
7964c7e 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2020

This pull request introduces 1 alert when merging 7964c7e into 78b6bef - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a class instantiation

ekmb added 3 commits June 2, 2020 16:03
@ekmb
typo
7c791ad 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
state dict splited
73120bc 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
merge
307b942 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request introduces 10 alerts when merging 307b942 into 1273d8f - view on LGTM.com

new alerts:

  • 7 for Variable defined multiple times
  • 2 for Unused import
  • 1 for Non-iterable used in for loop

@ekmb
lgtm fixes
b752fec 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request introduces 1 alert when merging b752fec into 1273d8f - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@tkornuta-nvidia tkornuta-nvidia self-requested a review June 3, 2020 22:39
@tkornuta-nvidia
fixing the process script, moved multiwoz_mapping.pair to multiwoz, e…
315bd79 
…nabled utilization of relative paths

Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
@tkornuta-nvidia
formatting fix
800b771 
Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request introduces 1 alert when merging 800b771 into 9a1366c - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@tkornuta-nvidia
reformatted the code, ready for definition of NG by connecting the mo…
fa33d33 
…dules - and fixing the definitions

Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
@tkornuta-nvidia
work in progress-ess, not working, internet issues
d913c65 
Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 1 alert when merging d913c65 into 1ae4aa9 - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@tkornuta-nvidia
UtteranceEncoder neural types wip
6f3980b 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 1 alert when merging 6f3980b into 1ae4aa9 - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@tkornuta-nvidia
utterance encoder neural types
0fc5372 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 2 alerts when merging 0fc5372 into 1ae4aa9 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Non-iterable used in for loop

@tkornuta-nvidia
updating trade outputs
0afa1bc 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
updating trade outputs
f822ec7 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
fightihg with belief state
7b9a899 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
Cannot make second named tuple work
a314765 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 2 alerts when merging 7b9a899 into 1273aff - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Non-iterable used in for loop

tkornuta-nvidia and others added 8 commits June 4, 2020 12:19
@tkornuta-nvidia
reorganized files, whole pipeline handshaking works
7de4074 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
reorganized files, whole pipeline handshaking works
82c274c 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
polish
8a8b7d9 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
Fix of my dummy error
f1c3855 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
new examples
2f5b4a7 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@ekmb
style fix
db3d410 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@ekmb
fixed TRADE training
f9f1d45 
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
@tkornuta-nvidia
Added module responsible for sys uttr dialog history update
9d97337 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 5, 2020

This pull request introduces 1 alert when merging 9d97337 into e14590b - view on LGTM.com

new alerts:

  • 1 for Unused import

@tkornuta-nvidia
LGTM fix
3bd914e 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@tkornuta-nvidia
moved dialog specific axesc andctypes to nlp/neural_types.py, refacto…
28b84b3 
…red the modules

Signed-off-by: nvidia <tkornuta@nvidia.com>
tkornuta-nvidia
tkornuta-nvidia previously approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@tkornuta-nvidia tkornuta-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to go with the current types

TODO (out-of-scope of this PR):

  1. unit test for "neural tuple"
  2. refactoring and unification of EncoderRNN

@tkornuta-nvidia
style fix
c802bdc 
Signed-off-by: nvidia <tkornuta@nvidia.com>
@ekmb ekmb merged commit 92ee0dd into master Jun 5, 2020
@ekmb ekmb deleted the pm_trade_port_refacto branch June 5, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkornuta-nvidia tkornuta-nvidia tkornuta-nvidia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekmb @tkornuta-nvidia