Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of documentation after package reorganization #349

Merged
merged 5 commits into from
Feb 12, 2020
Merged

Conversation

tkornuta-nvidia
Copy link
Contributor

@tkornuta-nvidia tkornuta-nvidia commented Feb 11, 2020

Fixed several Sphinx-related issues that probably resulted from the reorganizations of a) the packages in general and b) of NLP collection in particular.

DONE:

  • Cleaned up paths (EN/CN conf.py)
  • Added 'transformers.tokenization_bert' to mocked up modules (EN/CN conf.py)
  • Added 'transformers.tokenization_bert' to mocked up modules (EN/CN conf.py)
  • Fixed several references to whole modules (EN/CN)
  • Fixed several references to particular classes (EN/CN)

For example, .. automodule:: nemo.collections.nlp.huggingface.bert ->
.. automodule:: nemo.collections.nlp.nm.trainables.common.huggingface.bert

Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request introduces 1 alert when merging 09d4678 into 8d7bef6 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

Copy link
Contributor

@yzhang123 yzhang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import tokenizers as follows:
import nemo.collections.nlp as nemo_nlp
nemo_nlp.data.SentencePieceTokenizer

same for modules:

import nemo.collections.nlp as nemo_nlp
nemo_nlp.nm.[classifier]

pytorch_utils.py is gone after refactored

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request introduces 1 alert when merging 8bf4389 into 8d7bef6 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request introduces 1 alert when merging 9b5acd4 into 8d7bef6 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing :)

@tkornuta-nvidia tkornuta-nvidia merged commit 233a0fe into master Feb 12, 2020
@tkornuta-nvidia tkornuta-nvidia deleted the fix-doc branch February 12, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants