[WIP] Adding dialogue state tracking TRADE #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: Chip Nguyen <huyenntkvn@gmail.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: Vahid <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
|
This pull request introduces 4 alerts when merging 9d11dc2 into 75c4fb7 - view on LGTM.com new alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
|
This pull request introduces 3 alerts when merging 5d387ef into 75c4fb7 - view on LGTM.com new alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
|
This pull request introduces 2 alerts when merging bdb46d2 into 75c4fb7 - view on LGTM.com new alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
|
This pull request introduces 2 alerts when merging 5d37a1b into 75c4fb7 - view on LGTM.com new alerts:
|
tkornuta-nvidia
suggested changes
Feb 5, 2020
There was a problem hiding this comment.
Hi, this generally looks good!
My general comment is that I saw you put plenty of efforts into commenting e.g. input and output ports (which is good!), but majority of methods and functions are not commented at all (state_tracking_trade_dataset.py is a good example)
Minor: add shebang for scripts (e.g. preprocessing)
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
|
This pull request introduces 2 alerts when merging 5632f74 into 75c4fb7 - view on LGTM.com new alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
|
This pull request introduces 2 alerts when merging a26e11a into 75c4fb7 - view on LGTM.com new alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
tkornuta-nvidia
approved these changes
Feb 5, 2020
dcurran90
pushed a commit
to dcurran90/NeMo
that referenced
this pull request
Oct 15, 2024
* [LAB-307] Add paper link Signed-off-by: Trevor Grant <trevor.d.grant@gmail.com> * [LAB-307] Add paper link Signed-off-by: Trevor Grant <trevor.d.grant@gmail.com> * [LAB-307] Add paper link Signed-off-by: Trevor Grant <trevor.d.grant@gmail.com> --------- Signed-off-by: Trevor Grant <trevor.d.grant@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding TRADE (a dialogue state tracking model) to NeMo.
TRADE is introduced in the following paper:
"Transferable Multi-Domain State Generator for Task-Oriented Dialogue Systems", Chien-Sheng Wu, Andrea Madotto, Ehsan Hosseini-Asl, Caiming Xiong, Richard Socher and Pascale Fung. ACL 2019.
The model is adopted from:
https://github.com/jasonwu0731/trade-dst