-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nlp refactoring #316
nlp refactoring #316
Conversation
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 14 alerts and fixes 29 when merging fdc421b into 1fddca2 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 14 alerts and fixes 29 when merging 4f81260 into 1fddca2 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 11 alerts and fixes 29 when merging 0864e65 into 1fddca2 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 9 alerts and fixes 29 when merging 44bd381 into 1fddca2 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 10 alerts and fixes 29 when merging b3c1513 into 1fddca2 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com> # Conflicts: # scripts/export_bert_to_trt.py # tests/asr/test_asr.py # tests/asr/test_weight_share.py # tests/asr/test_zeroDS.py # tests/test_pytorch_trainers.py # tests/tts/test_tts.py
This pull request introduces 5 alerts and fixes 32 when merging 2137704 into 4137c2b - view on LGTM.com new alerts:
fixed alerts:
|
nemo/collections/nlp/data/datasets/punctuation_capitalization_dataset.py
Show resolved
Hide resolved
nemo/collections/nlp/nm/trainables/common/transformer/transformer_modules.py
Outdated
Show resolved
Hide resolved
nemo/collections/nlp/nm/trainables/common/transformer/transformer_nm.py
Outdated
Show resolved
Hide resolved
It would be very helpful if you can add copyright headers on all new files |
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 5 alerts and fixes 32 when merging b8f57bf into 4137c2b - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 8 alerts and fixes 36 when merging 720f5c5 into b4aba85 - view on LGTM.com new alerts:
fixed alerts:
|
Standardize:
|
|
please don't merge yet, some of the examples are broken |
@ekmb you can request changes to block merging |
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
This pull request introduces 24 alerts and fixes 36 when merging 04a083b into b4aba85 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
…into nlp_refactoring_tmp
Signed-off-by: Evelina Bakhturina <ebakhturina@nvidia.com>
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
…into nlp_refactoring_tmp
…into nlp_refactoring_tmp
This pull request introduces 10 alerts and fixes 36 when merging 21f353b into b4aba85 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
…into nlp_refactoring_tmp
Signed-off-by: VahidooX <vnoroozi@nvidia.com>
This pull request introduces 10 alerts and fixes 36 when merging 4cbcfd4 into b4aba85 - view on LGTM.com new alerts:
fixed alerts:
|
* Fix formatting and linting Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> * Update after review Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> * Update after review Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> --------- Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
New PR for #295 that does not touch all files.
Changes to the nemo nlp collection:
++updated the organization of the files, functions, and classes
++**names of all the nlp related files are updated to more appropriate names
++**data_layers.py is split into separate files for each data layer
++**all utils and functions related to datasets are moved into datasets folder
++**all tokenizers are organized into a folder under datasets
++added copyright headers to all files in the collection
++replaced all prints with logging
++fixed and adopted new style
++updated all the files and fixed the imports to avoid polluting the namespace with import *
++merged with nemo refactoring updates