Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger Update 2: fix unused import and squad #283

Merged
merged 8 commits into from
Jan 22, 2020

Conversation

blisc
Copy link
Collaborator

@blisc blisc commented Jan 21, 2020

Updates #270 to use the new logging method
Fix some LGTM issues

blisc and others added 6 commits January 21, 2020 14:43
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Tomasz Kornuta <tkornuta@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request introduces 1 alert and fixes 7 when merging f75d7e6 into bc0d7b1 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 4 for Suspicious unused loop iteration variable
  • 2 for Redundant assignment
  • 1 for Unused import

Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request fixes 7 alerts when merging e18015d into bc0d7b1 - view on LGTM.com

fixed alerts:

  • 4 for Suspicious unused loop iteration variable
  • 2 for Redundant assignment
  • 1 for Unused import

Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2020

This pull request fixes 8 alerts when merging c84cc56 into bc0d7b1 - view on LGTM.com

fixed alerts:

  • 4 for Suspicious unused loop iteration variable
  • 2 for Redundant assignment
  • 1 for Unused import
  • 1 for Nested loops with same variable

Copy link
Contributor

@tkornuta-nvidia tkornuta-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! :)

@tkornuta-nvidia tkornuta-nvidia merged commit 30db6f2 into NVIDIA:master Jan 22, 2020
@blisc blisc deleted the u_logging_update_2 branch January 25, 2020 01:20
dcurran90 pushed a commit to dcurran90/NeMo that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants