Fix/nvidia ai endpoints streaming #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a factory pattern to create a patched version of ChatNVIDIA based on the version of the langchain_nvidia_ai_endpoints package. Two patched versions are created for the version ranges 0.1. - 0.2.0 and 0.2.0 - 0.3.0. The ChatNVIDIAFactory is responsible for checking the package version and returning the corresponding patched class. The patched class is then assigned to ChatNVIDIA, which will be used in providers.
This commit modifies the import statement in the providers module to import the patched version of ChatNVIDIA from the _langchain_nvidia_ai_endpoints_patch module.
drazvan
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the streaming issue introduced with langchain_nvidia_ai_endpoints package.
It creates a patched version of
ChatNVIDIAbased on the version of thelangchain_nvidia_ai_endpointspackage. Two patched versions are created for the version ranges 0.1. - 0.2.0 and 0.2.0 - 0.3.0. TheChatNVIDIAFactoryis responsible for checking the package version and returning the corresponding patched class. The patched class is then assigned toChatNVIDIA, which will be used in providers.Imodifies the import statement in the providers module to import the patched version of ChatNVIDIA from the _langchain_nvidia_ai_endpoints_patch module.
it is tested on
langchain_nvidia_ai_endpointsversions 0.1.3.0 - 0.1.4 - 0.1.5 - 0.1.6 - 0.1.7 and 0.2.0