-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Cleanlab's Trustworthiness Score #572
Conversation
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
@AshishSardana : Yes, you can add it in the library documentation. We are in the process of refactoring the structure a bit, but we'll change this as well once that's finalized. |
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take this review with a grain of salt. My comments are mainly to make our documentation more clear and succinct. I also try to facilitate usage of Cleanlab by using phrases like "It's easy to get started by doing X, Y and Z" instead of "It is required to do X if you want to use cleanlab"
I have some comments that are really more a preference, which I've prefaced with "Nit"
Co-authored-by: Nelson Auner <nelson@auner.org> Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Co-authored-by: Nelson Auner <nelson@auner.org> Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
…Guardrails into feature/cleanlab-tlm
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
I'm not sure how the commit history got duplicated with my last a7517e3 commit. No new changes are introduced in these duplicate commits. |
Co-authored-by: Jonas Mueller <1390638+jwmueller@users.noreply.github.com> Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Hi @drazvan, the PR is ready for review. Could you please give it a look? |
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Signed-off-by: Ashish Sardana <ashishsardana21@gmail.com>
Hi @Pouyanpi , I've resolved the conflicts. |
Hi @Pouyanpi, please feel free to ask any clarifying questions! |
@AshishSardana, I'm just reviewing this, apologies for the delay. The code looks good, however, when I try to run it, I'm running into an error coming from the CleanLab python client.
rails:
# input:
# flows:
# - self check input
output:
flows:
- cleanlab trustworthiness
(comment the self-check input and replace the self-check output with cleanlab trustworthiness).
Relevant error:
From what I can see, the Let me know if you're able to reproduce |
@drazvan I was able to reproduce this error. We've pushed a fix to the cleanlab-studio package that you can fetch by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test and looks good 👍. Latency was a bit high in my tests, ~5s, but I guess that will be improved.
Cleanlab provides trustworthiness score that can be used for guardrailing tasks. Read more about how this score is calculated here.
This PR aims to add support for a 3rd party API i.e. Cleanlab Studio's API, to enable users to use trustworthiness score for using guardrails on output.