Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make errors when importing actions more visible #335

Closed
drazvan opened this issue Feb 16, 2024 · 1 comment
Closed

Make errors when importing actions more visible #335

drazvan opened this issue Feb 16, 2024 · 1 comment
Assignees
@Pouyanpi
Labels
enhancement New feature or request status: in progress Issues that are currently being worked on.
Milestone
v0.10.0

Comments

@drazvan
Copy link
Collaborator

drazvan commented Feb 16, 2024

Right now, the import fails silently and typically you get an "Action not found" error.
@drazvan drazvan added the enhancement New feature or request label Feb 16, 2024
@drazvan drazvan added this to the v0.9.0 milestone Feb 16, 2024
@drazvan drazvan modified the milestones: v0.8.2, v0.10.0 Apr 15, 2024
@Pouyanpi
Copy link
Collaborator

Hi @drazvan!
To clarify, the current implementation invokes _internal_error_action_result when an action is not found. Are you suggesting that we should raise an ImportError or ColangRuntimeError instead when this occurs?

@Pouyanpi Pouyanpi added status: needs info Issues that require more information from the reporter to proceed. status: in progress Issues that are currently being worked on. labels Jun 3, 2024
@Pouyanpi Pouyanpi mentioned this issue Jun 7, 2024
Merged
@Pouyanpi Pouyanpi removed the status: needs info Issues that require more information from the reporter to proceed. label Jun 7, 2024
@Pouyanpi Pouyanpi closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pouyanpi Pouyanpi

Labels
enhancement New feature or request status: in progress Issues that are currently being worked on.
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@drazvan @Pouyanpi