Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow new line characters inside predefined bot messages #216

Closed
drazvan opened this issue Dec 11, 2023 · 3 comments · Fixed by #544
Closed

Allow new line characters inside predefined bot messages #216

drazvan opened this issue Dec 11, 2023 · 3 comments · Fixed by #544
Assignees
@Pouyanpi
Labels
good first issue Good for newcomers status: help wanted Issues where external contributions are encouraged. status: waiting confirmation Issue is waiting confirmation whether the proposed solution/workaround works.
Milestone
v0.10.0

Comments

@drazvan
Copy link
Collaborator

drazvan commented Dec 11, 2023

If "\n" is used inside a predefined bot message, it will be returned as is as part of the message. It should be translated to an actual \n character.
@drazvan drazvan added good first issue Good for newcomers status: help wanted Issues where external contributions are encouraged. labels Dec 11, 2023
@madangopal16072000
Copy link

I am interested in contributing to this issue. Since I am new to this project can you please point to necessary files.

@drazvan
Copy link
Collaborator Author

drazvan commented Dec 14, 2023

Thanks @madangopal16072000 !

One way to go about this is to check the content of the bot_utterance here and replace all "\n" with the actual \n character.

Make sure you also add a simple test for this.

Thanks!

@drazvan drazvan added this to the v0.7.0 milestone Dec 14, 2023
@drazvan drazvan modified the milestones: v0.7.0, v0.8.0 Jan 31, 2024
@drazvan
Copy link
Collaborator Author

drazvan commented Feb 29, 2024

@madangopal16072000 : are you still interested in contributing this?

@drazvan drazvan modified the milestones: v0.8.0, v0.9.0 Feb 29, 2024
@madangopal16072000 madangopal16072000 removed their assignment Mar 2, 2024
@drazvan drazvan modified the milestones: v0.8.2, v0.10.0 Apr 15, 2024
@Pouyanpi Pouyanpi added the status: in progress Issues that are currently being worked on. label May 28, 2024
Pouyanpi added a commit that referenced this issue May 30, 2024
@Pouyanpi
Fix issue #216 Clean utterance content in LLMGenerationActions
6265c96
Pouyanpi added a commit that referenced this issue Jun 5, 2024
@Pouyanpi
Fix issue #216 Clean utterance content in LLMGenerationActions
b3c0054
@Pouyanpi Pouyanpi mentioned this issue Jun 5, 2024
Merged
@Pouyanpi Pouyanpi added status: waiting confirmation Issue is waiting confirmation whether the proposed solution/workaround works. and removed status: in progress Issues that are currently being worked on. labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pouyanpi Pouyanpi

Labels
good first issue Good for newcomers status: help wanted Issues where external contributions are encouraged. status: waiting confirmation Issue is waiting confirmation whether the proposed solution/workaround works.
Projects
None yet
Milestone
v0.10.0
3 participants
@drazvan @Pouyanpi @madangopal16072000