Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Add reliable xgboost documentation #2471

Merged

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Add reliable xgboost documentation

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen
Copy link
Collaborator

I felt this is not a complete documentation, simply add the design doc to the user guide is not enough. We really need to add a higher level documentation to explain what's this feature, why it is needed, what's the potential trade offs etc. instead directly jump into implementation and configuration.

Although some of the information is already provided, we have surface up in the user-level doc. The implementation design doc is for those who interested in the details

@YuanTingHsieh YuanTingHsieh added the documentation Improvements or additions to documentation label Apr 9, 2024
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's improve later. approve for now

@chesterxgchen chesterxgchen merged commit 40cff16 into NVIDIA:2.4 Apr 9, 2024
13 of 14 checks passed
@YuanTingHsieh YuanTingHsieh deleted the add_reliable_xgboost_document_24 branch April 10, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants