Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Enable StreamCell for all application channels #2406

Merged
merged 2 commits into from
Mar 18, 2024
Merged

[2.4] Enable StreamCell for all application channels #2406

merged 2 commits into from
Mar 18, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

CellPipe's channel or all user defined application channels should have streaming capabilities unless otherwise opt out.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 18, 2024
Merged
6 tasks
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 18, 2024
Closed
6 tasks
yanchengnv
yanchengnv approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacYangSLA
Copy link
Collaborator

/build

1 similar comment
@IsaacYangSLA
Copy link
Collaborator

/build

@IsaacYangSLA IsaacYangSLA merged commit b959e90 into NVIDIA:2.4 Mar 18, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the enable_cell_pipe_streaming_24 branch March 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@yanchengnv yanchengnv yanchengnv approved these changes

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@yhwen yhwen Awaiting requested review from yhwen

@SYangster SYangster Awaiting requested review from SYangster

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@nvidianz nvidianz Awaiting requested review from nvidianz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YuanTingHsieh @IsaacYangSLA @chesterxgchen @yanchengnv