Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFRecord to support S3 index URIs #5515

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Jun 10, 2024

Category:

Bug fix

Description:

Additional information:

Affected modules and functionalities:

Indexed file loader (TFRecord reader)

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A
    Need to figure out the S3 storage infrastructure for testing first.

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3995

@jantonguirao jantonguirao force-pushed the s3_tfrecord branch 2 times, most recently from f0cfd19 to 616c93c Compare June 11, 2024 08:26
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15735775]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15735775]: BUILD FAILED

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15741123]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15741123]: BUILD PASSED

@jantonguirao jantonguirao merged commit 9420fb8 into NVIDIA:main Jun 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compressed TFRecord and indexes stored on s3
4 participants