Move fit and node to core #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
approved these changes
May 23, 2023
Documentation preview |
| @property | ||
| def supported_formats(self) -> DataFormats: | ||
| return DataFormats.PANDAS_DATAFRAME | DataFormats.CUDF_DATAFRAME | ||
| Operator = BaseOperator |
oliverholworthy
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls nvtabular to leverage more from core. This PR is dependent on NVIDIA-Merlin/core#324 in core.
Moved StatOperator to core
Replaced workflow Fit with fit in executor in core
Replaced WorkflowNode with Node in core
Updated all statoperators to inherit from StatOperator in core
Replaced Operator with base operator from core
This centralizes more code about operators and graph execution in core so that it can be leveraged by other repos throughout merlin (i.e. Systems)