WAR for hugectr gmock build error #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
jperez999
approved these changes
May 17, 2023
|
This has been approved. However, removing tests is not really a good solution to getting things working. We want tests to run and pass ideally. |
|
@jperez999 this is a WAR but we actually don't remove the tests. It is more like removing those libs in the base container, so that they don't block the build in the ctr container. The ctr container reinstalls those tests. We will find a better way to do it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we hit conflicts of gtest/gmock error when build merlin-hugectr(I also saw this error in Merlin ci main - rel). Here is the WAR. We may need more time to fix.
Could you review and approve? Thanks!