Install hps backend and hps trt plugin in hugectr/tf/pytorch #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EmmaQiaoCh
commented
Jan 4, 2023
•
EmmaQiaoCh
commented
- Install common dependencies in merlin-base;
- Install related components(hugectr inference, hps_backend, hps trt plugin) in merlin-base, merlin-hugectr/merlin-tf/merlin-pytorch all need it;
- copy arrow and parquet headers and cmake folder;
- specified tritonserverclient to an older version and copy the perf_* binaries which is needed by hugectr
Documentation preview |
|
This looks good. My only comment here is that it looks like this now gets installed in all of the containers, so it probably makes sense to move the install to the base container so we only have to write and maintain it in one place. |
EmmaQiaoCh
changed the title
EmmaQiaoCh
force-pushed
the
install_hps_backend_emma
branch
from
92d8952
to
10318d0
Compare
|
@jperez999 to test and report on the size of the container |
EmmaQiaoCh
force-pushed
the
install_hps_backend_emma
branch
from
6a06990
to
76d41cd
Compare
jperez999
requested changes
Feb 16, 2023
EmmaQiaoCh
changed the title
jperez999
approved these changes
Mar 6, 2023
|
forcing this through for container release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.