Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Merlin libs graphic #560

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

mikemckiernan
Copy link
Member

Fixes #170

  • In the DATA LOADER column, add "Merlin Dataloader" instead
    of NVTabular (since we're migrating that to a separate library).

  • In the TRAINING column, add boxes for "Transformers4Rec" and
    "Merlin Models." Leaving the existing box for TensorFlow/PyTorch.

  • In the INFERENCE column, add a box for Merlin Systems in addition
    to Triton.

@mikemckiernan mikemckiernan self-assigned this Aug 25, 2022
@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Aug 25, 2022
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #560 of commit 34ea1f58b1a498e969aa45894c9030f97d5344a5, no merge conflicts.
Running as SYSTEM
Setting status of 34ea1f58b1a498e969aa45894c9030f97d5344a5 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/371/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/560/*:refs/remotes/origin/pr/560/* # timeout=10
 > git rev-parse 34ea1f58b1a498e969aa45894c9030f97d5344a5^{commit} # timeout=10
Checking out Revision 34ea1f58b1a498e969aa45894c9030f97d5344a5 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 34ea1f58b1a498e969aa45894c9030f97d5344a5 # timeout=10
Commit message: "Update Merlin libs graphic"
 > git rev-list --no-walk 3832ea55a7cc44dce1f693d5e718ddc49a12f1a6 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins11362955600566492755.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 3 items

tests/unit/test_version.py . [ 33%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py s [ 66%]
tests/unit/examples/test_scaling_criteo_merlin_models.py . [100%]

=============================== warnings summary ===============================
../../../../../usr/local/lib/python3.8/dist-packages/dask_cudf/core.py:33
/usr/local/lib/python3.8/dist-packages/dask_cudf/core.py:33: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
DASK_VERSION = LooseVersion(dask.version)

../../../.local/lib/python3.8/site-packages/setuptools/_distutils/version.py:346: 34 warnings
/var/jenkins_home/.local/lib/python3.8/site-packages/setuptools/_distutils/version.py:346: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
other = LooseVersion(other)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============ 2 passed, 1 skipped, 35 warnings in 111.43s (0:01:51) =============
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins8188248626807749517.sh

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-560

Fixes NVIDIA-Merlin#170

* In the DATA LOADER column, add "Merlin Dataloader" instead
  of NVTabular (since we're migrating that to a separate library).

* In the TRAINING column, add boxes for "Transformers4Rec" and
  "Merlin Models." Leaving the existing box for TensorFlow/PyTorch.

* In the INFERENCE column, add a box for Merlin Systems in addition
  to Triton.

Incorporate feedback from Karl: Put systems on top of Triton.
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #560 of commit 9de242652d08e80e3789ae54510fc57efe3bce00, no merge conflicts.
Running as SYSTEM
Setting status of 9de242652d08e80e3789ae54510fc57efe3bce00 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/372/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/560/*:refs/remotes/origin/pr/560/* # timeout=10
 > git rev-parse 9de242652d08e80e3789ae54510fc57efe3bce00^{commit} # timeout=10
Checking out Revision 9de242652d08e80e3789ae54510fc57efe3bce00 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 9de242652d08e80e3789ae54510fc57efe3bce00 # timeout=10
Commit message: "Update Merlin libs graphic"
 > git rev-list --no-walk 34ea1f58b1a498e969aa45894c9030f97d5344a5 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins1008961036893830962.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 3 items

tests/unit/test_version.py . [ 33%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py s [ 66%]
tests/unit/examples/test_scaling_criteo_merlin_models.py . [100%]

=============================== warnings summary ===============================
../../../../../usr/local/lib/python3.8/dist-packages/dask_cudf/core.py:33
/usr/local/lib/python3.8/dist-packages/dask_cudf/core.py:33: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
DASK_VERSION = LooseVersion(dask.version)

../../../.local/lib/python3.8/site-packages/setuptools/_distutils/version.py:346: 34 warnings
/var/jenkins_home/.local/lib/python3.8/site-packages/setuptools/_distutils/version.py:346: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
other = LooseVersion(other)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============ 2 passed, 1 skipped, 35 warnings in 112.43s (0:01:52) =============
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins11627801258121836919.sh

@karlhigley karlhigley merged commit 1a8f131 into NVIDIA-Merlin:main Aug 25, 2022
@viswa-nvidia viswa-nvidia added this to the Merlin 22.09 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the top level Merlin image to include new libraries
4 participants