Add NGC overview descriptions for our containers #399

benfred · 2022-06-16T22:19:22Z

This adds the markdown text for our NGC overview section. The idea here is to
let us come together and figure out the best descriptions as a team, before
pushing out the description to NGC for the new containers.

This is a draft, merging the descriptions from the training/inference containers
together so that we can use with the unified containers

This adds the markdown text for our NGC overview section. The idea here is to let us come together and figure out the best descriptions as a team, before pushing out the description to NGC for the new containers. This is a draft, merging the descriptions from the training/inference containers together so that we can use with the unified containers

nvidia-merlin-bot · 2022-06-16T22:19:36Z

Click to view CI Results

GitHub pull request #399 of commit 5cd70a4e0b6407ae65a337f550d04d30b5631b54, no merge conflicts.
Running as SYSTEM
Setting status of 5cd70a4e0b6407ae65a337f550d04d30b5631b54 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/179/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/399/*:refs/remotes/origin/pr/399/* # timeout=10
 > git rev-parse 5cd70a4e0b6407ae65a337f550d04d30b5631b54^{commit} # timeout=10
Checking out Revision 5cd70a4e0b6407ae65a337f550d04d30b5631b54 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5cd70a4e0b6407ae65a337f550d04d30b5631b54 # timeout=10
Commit message: "Add NGC overview descriptions for our containers"
 > git rev-list --no-walk 26c9fab2fd7a93f38de332b57230f1a18560d073 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins4532858464002029498.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item / 1 skipped
tests/unit/test_version.py .                                             [100%]
========================= 1 passed, 1 skipped in 2.36s =========================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_merlin] $ /bin/bash /tmp/jenkins3420854601635621118.sh

github-actions · 2022-06-16T22:22:21Z

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-399

mikemckiernan

My comments are a little more involved than I anticipated. I'm happy to make these changes (if others agree) and get this to NGC--just point me to the correct process or person.

docker/ngc_overview_hugectr.md

nvidia-merlin-bot · 2022-06-23T22:51:11Z

Click to view CI Results

GitHub pull request #399 of commit 0ea7e108be35493209fd81082d5a934990bad29e, no merge conflicts.
Running as SYSTEM
Setting status of 0ea7e108be35493209fd81082d5a934990bad29e to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/197/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/399/*:refs/remotes/origin/pr/399/* # timeout=10
 > git rev-parse 0ea7e108be35493209fd81082d5a934990bad29e^{commit} # timeout=10
Checking out Revision 0ea7e108be35493209fd81082d5a934990bad29e (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0ea7e108be35493209fd81082d5a934990bad29e # timeout=10
Commit message: "suggestions from code review"
 > git rev-list --no-walk c2aa400373793509da5e594bd36e8d10fe691a53 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins2854318358918577026.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
tests/unit/test_version.py .                                             [ 50%]

tests/unit/examples/test_building_deploying_multi_stage_RecSys.py .      [100%]
======================== 2 passed in 146.54s (0:02:26) =========================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_merlin] $ /bin/bash /tmp/jenkins10913574680279634212.sh

benfred · 2022-06-23T22:52:42Z

Thanks for the review @mikemckiernan! I've incorporated your suggestions in the last commit. I think it looks quite a bit better now.

If you have further changes you'd like to see - just let me know (or file a new PR =). In terms of getting this change onto NGC, right now I'll have to update the descriptions manually. The access to the NGC account is locked down, and we've had to make some promises that we wouldn't share the account details beyond me/Even/Julio. I'm thinking we can maintain the version of what text we'd like to see on NGC here - and then once its merged you can ping me or Julio to sync up to ngc.

nvidia-merlin-bot · 2022-06-23T22:53:36Z

Click to view CI Results

GitHub pull request #399 of commit d969710796dfc840e1a69194d861070eb6a4d007, no merge conflicts.
Running as SYSTEM
Setting status of d969710796dfc840e1a69194d861070eb6a4d007 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/198/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/399/*:refs/remotes/origin/pr/399/* # timeout=10
 > git rev-parse d969710796dfc840e1a69194d861070eb6a4d007^{commit} # timeout=10
Checking out Revision d969710796dfc840e1a69194d861070eb6a4d007 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d969710796dfc840e1a69194d861070eb6a4d007 # timeout=10
Commit message: "Merge branch 'main' into ngc_overview"
 > git rev-list --no-walk 0ea7e108be35493209fd81082d5a934990bad29e # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins8788275541014389389.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
tests/unit/test_version.py .                                             [ 50%]

tests/unit/examples/test_building_deploying_multi_stage_RecSys.py .      [100%]
======================== 2 passed in 142.29s (0:02:22) =========================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_merlin] $ /bin/bash /tmp/jenkins8027066532814534547.sh

nvidia-merlin-bot · 2022-06-24T21:05:53Z

Click to view CI Results

GitHub pull request #399 of commit 5bbc1eb6712d321c7653e065a7ef353692b1c952, no merge conflicts.
Running as SYSTEM
Setting status of 5bbc1eb6712d321c7653e065a7ef353692b1c952 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/201/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/399/*:refs/remotes/origin/pr/399/* # timeout=10
 > git rev-parse 5bbc1eb6712d321c7653e065a7ef353692b1c952^{commit} # timeout=10
Checking out Revision 5bbc1eb6712d321c7653e065a7ef353692b1c952 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5bbc1eb6712d321c7653e065a7ef353692b1c952 # timeout=10
Commit message: "Merge branch 'main' into ngc_overview"
 > git rev-list --no-walk 8164ebec5bf5089ac546ad3936f4ec1d825e0045 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins6376353946360846539.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
tests/unit/test_version.py .                                             [ 50%]

tests/unit/examples/test_building_deploying_multi_stage_RecSys.py .      [100%]
======================== 2 passed in 124.77s (0:02:04) =========================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_merlin] $ /bin/bash /tmp/jenkins17189777944998550616.sh

benfred added the documentation Improvements or additions to documentation label Jun 16, 2022

mikemckiernan reviewed Jun 17, 2022

View reviewed changes

benfred added 3 commits June 23, 2022 15:38

Suggestions from code review

e6a489e

suggestions from code review

0ea7e10

Merge branch 'main' into ngc_overview

d969710

jperez999 approved these changes Jun 23, 2022

View reviewed changes

Merge branch 'main' into ngc_overview

5bbc1eb

benfred merged commit 31a581b into main Jun 24, 2022

benfred deleted the ngc_overview branch June 24, 2022 21:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add NGC overview descriptions for our containers #399

Add NGC overview descriptions for our containers #399

benfred commented Jun 16, 2022

nvidia-merlin-bot commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

mikemckiernan left a comment

nvidia-merlin-bot commented Jun 23, 2022

benfred commented Jun 23, 2022 •

edited

Loading

nvidia-merlin-bot commented Jun 23, 2022

nvidia-merlin-bot commented Jun 24, 2022

Add NGC overview descriptions for our containers #399

Add NGC overview descriptions for our containers #399

Conversation

benfred commented Jun 16, 2022

nvidia-merlin-bot commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

Documentation preview

mikemckiernan left a comment

Choose a reason for hiding this comment

nvidia-merlin-bot commented Jun 23, 2022

benfred commented Jun 23, 2022 • edited Loading

nvidia-merlin-bot commented Jun 23, 2022

nvidia-merlin-bot commented Jun 24, 2022

benfred commented Jun 23, 2022 •

edited

Loading