Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict tritonclient to 2.22.0 #391

Merged
merged 3 commits into from
Jun 16, 2022

Conversation

EmmaQiaoCh
Copy link
Contributor

  • Restrict tritonclient to version 2.22.0
  • The latest version 2.22.3 has permission issue

* The latest version 2.22.3 has permission issue
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #391 of commit 52affdfb2de90a14031b273c42b08da90fe86cb3, no merge conflicts.
Running as SYSTEM
Setting status of 52affdfb2de90a14031b273c42b08da90fe86cb3 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/156/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/391/*:refs/remotes/origin/pr/391/* # timeout=10
 > git rev-parse 52affdfb2de90a14031b273c42b08da90fe86cb3^{commit} # timeout=10
Checking out Revision 52affdfb2de90a14031b273c42b08da90fe86cb3 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 52affdfb2de90a14031b273c42b08da90fe86cb3 # timeout=10
Commit message: "Restrict tritonclient to 2.22.0"
 > git rev-list --no-walk a2e49208f618f222ad0c5e69efed35e27417e577 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7600507067030654850.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins13903391597118046633.sh

@jperez999
Copy link
Collaborator

@EmmaQiaoCh Can we ask for more information on why this is needed. We are trying to move away from version anchoring any packages that dont absolutely need it. And we rely on the proto message from the tritonclient so we would like to keep them as up-to-date as possible? @benfred @EvenOldridge for viz

@EmmaQiaoCh
Copy link
Contributor Author

Hi @jperez999 , we met a permission issue with the latest version of tritonclient(I opened this issue for triton: triton-inference-server/server#4511) . /usr/local/bin/perf_analyzer and /usr/local/bin/perf_client don't have execution permission and which worked several days ago. So wondering if we could use the version 2.22.0 until the big fix. Thanks.

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #391 of commit f9382408cf69201c801004edfbea98a1d3e52178, no merge conflicts.
Running as SYSTEM
Setting status of f9382408cf69201c801004edfbea98a1d3e52178 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/172/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/391/*:refs/remotes/origin/pr/391/* # timeout=10
 > git rev-parse f9382408cf69201c801004edfbea98a1d3e52178^{commit} # timeout=10
Checking out Revision f9382408cf69201c801004edfbea98a1d3e52178 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f9382408cf69201c801004edfbea98a1d3e52178 # timeout=10
Commit message: "Merge branch 'main' into update_tritonclient"
 > git rev-list --no-walk d29fe471d652ee47f14682a03ffaca2e98c85a3a # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins14878476865231010469.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item / 1 skipped

tests/unit/test_version.py . [100%]

========================= 1 passed, 1 skipped in 2.37s =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins927725253695795785.sh

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-391

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #391 of commit 1249216338c082da73141e910864cf79adaeca91, no merge conflicts.
Running as SYSTEM
Setting status of 1249216338c082da73141e910864cf79adaeca91 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/176/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/391/*:refs/remotes/origin/pr/391/* # timeout=10
 > git rev-parse 1249216338c082da73141e910864cf79adaeca91^{commit} # timeout=10
Checking out Revision 1249216338c082da73141e910864cf79adaeca91 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1249216338c082da73141e910864cf79adaeca91 # timeout=10
Commit message: "Merge branch 'main' into update_tritonclient"
 > git rev-list --no-walk 929dba5092138778aece138ed3b64b8a7901a4a3 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7816790716648170886.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item / 1 skipped

tests/unit/test_version.py . [100%]

========================= 1 passed, 1 skipped in 2.38s =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins3569629791980578422.sh

@benfred benfred merged commit f17de0c into NVIDIA-Merlin:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants