Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torch horovod: explicitly does not need tensorflow #206

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

jperez999
Copy link
Collaborator

the install is requiring Tensorflow now. It must be omitted according to https://github.com/horovod/horovod/blob/master/docs/install.rst#tensorflow.

@jperez999 jperez999 requested a review from benfred April 13, 2022 22:03
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #206 of commit fd8259afe2a19f0c2d47a39c55ca1b0937ac5e11, no merge conflicts.
Running as SYSTEM
Setting status of fd8259afe2a19f0c2d47a39c55ca1b0937ac5e11 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/38/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/206/*:refs/remotes/origin/pr/206/* # timeout=10
 > git rev-parse fd8259afe2a19f0c2d47a39c55ca1b0937ac5e11^{commit} # timeout=10
Checking out Revision fd8259afe2a19f0c2d47a39c55ca1b0937ac5e11 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f fd8259afe2a19f0c2d47a39c55ca1b0937ac5e11 # timeout=10
Commit message: "fix torch horovod explicit do not need tensorflow"
 > git rev-list --no-walk efd6fe34c93fed1de1e7c754dbbabf430b98ef27 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins6581413910975784817.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins6209801380566426992.sh

@jperez999 jperez999 merged commit 6025a52 into NVIDIA-Merlin:main Apr 13, 2022
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants