Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still in draft stage and isn't expected to get out of that for a while. Updates to Readers are likely needed.
This PR also branched off of #739, so some of the changes are linked to that PR.
Reviewer Checklist
Related Issues
fixes #737
Testing Instructions
Will provide once command is stable.
Summary
This will be held as a draft until we can get the output of readers consistent. For example, when testing with reader
abi_netcdf
, different xarray_dicts are returned depending if anarea_def
is specified or not. If noarea_def
is specified, the xarray_dict will look like:{"LOW": xobj, "MED": xobj, "HIGH": xobj, "METADATA": xobj}
. Ifarea_def
is specified, the xarray_dict will look like:{"sector_name": xobj, "METADATA": xobj}
. Due to these inconsistencies, we cannot provide the same structure of data for each reader.This PR also adds the command
geoips --version
, as requested by @mindyls. I additionally play along with validating the output of readers, though this is still in development as I need to figure out how to linkBaseReaderPlugin:validate_output
to the end of a reader plugin's__call__
method.Initial stage of CLI command
geoips describe data
. This command will describe the data that will come out of a reader. Its signature isgeoips describe data <reader_name> <file_paths>
. Expected output will look along the lines ofOutput
Here is the current example of running
geoips describe data abi_netcdf /home/evan/geoips/geoips_packages/test_data/test_data_noaa_aws/data/goes16/20200918/1950/*
, where we provide apostage
sector for quick processing. Note that no resolutions are specified underDatasets
.