Fix purposeful invalid UTF-8 test when running in NodeJS v0.10.42+.

NREL · Jun 5, 2016 · 2a329ad · 2a329ad
1 parent e4a513d
commit 2a329ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/circle.yml b/circle.yml
@@ -14,7 +14,7 @@ machine:
     # don't conflict with our embedded ruby installation.
     - rvm reset
   node:
-    version: 0.10.40
+    version: 0.10.45
 dependencies:
   cache_directories:
     - build/work

diff --git a/test/integration/logging.js b/test/integration/logging.js
@@ -839,7 +839,13 @@ describe('logging', function() {
     var expectedRawBinary = new Buffer('77+9', 'base64').toString();
 
     var args = 'url_encoded=' + urlEncoded + '&base64ed=' + base64ed + '&raw=' + raw;
-    request({
+
+    // Use curl and not request for this test, since node's HTTP parser
+    // prevents invalid utf8 characters from being used in headers as of NodeJS
+    // v0.10.42. But we still want to test this, since other clients can still
+    // pass invalid utf8 characters.
+    var curl = new Curler();
+    curl.request({
       method: 'GET',
       url: 'http://localhost:9080/info/' + urlEncoded + '/' + base64ed + '/' + raw + '/?api_key=' + this.apiKey + '&unique_query_id=' + this.uniqueQueryId + '&' + args,
       headers: {