Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding methods for Single Optimization Container #6

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Adding methods for Single Optimization Container #6

merged 2 commits into from
Aug 21, 2024

Conversation

sourabhdalvi
Copy link

This PR adds methods for the following

  • adding parameters to the container
  • adding expressions to the container

@sourabhdalvi sourabhdalvi self-assigned this Aug 13, 2024
@rodrigomha
Copy link
Contributor

Let's add the parameters for now, but we may not needed later.

Is this ready for review?

@sourabhdalvi sourabhdalvi marked this pull request as ready for review August 15, 2024 21:40
@rodrigomha rodrigomha merged commit c7eefac into rh/optimization_container_dev Aug 21, 2024
0 of 5 checks passed
@sourabhdalvi sourabhdalvi deleted the sd/opt_container_dev branch September 3, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigomha rodrigomha rodrigomha approved these changes

Assignees

@sourabhdalvi sourabhdalvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourabhdalvi @rodrigomha