FEAT: Have 'find_library' search through LD_LIBRARY_PATH, if set. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporated fix from grib2io for macOSX on Apple Silicon.
|
Why are dropping support for Python 3.8 on macOS? I updated main today to support NCEPLIBS-ip v5.0.0 which includes a find_library update (same one from grib2io). |
|
Temporarily dropped macos Python 3.8 to make sure all the other macos versions worked. I realized after that I could have turned off fast_fail, but definitely 3.8 will be available for macos. |
|
Can you update your branch and this PR and mark ready for review? Also, lets remove setup.py changes. Most of these changes have made their way into what is in main from all of the static libs work, etc. |
|
I am going to merge this. I have some ideas to test for macos and windows testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework find_library to support Windows and on Linux/Unix search through LD_LIBRARY_PATH.