Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set grib2io as a dependency #13

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

TimothyCera-NOAA
Copy link
Contributor

No description provided.

@EricEngle-NOAA
Copy link
Contributor

What was the rationale for having grib2io as a dependency? I know it makes sense...but just wondering.

@TimothyCera-NOAA
Copy link
Contributor Author

I don't recall any other reason than that you can't use grib2io-interp without grib2io. I think if someone sees grib2io-interp first they might think, "This is the interpolation version of grib2io" and just install grib2io-interp. With this dependency they would actually get the interpolation version of grib2io. That's all I got.

@EricEngle-NOAA
Copy link
Contributor

Technically grib2io is not required. If you had the appropriate GRIB2 grid definition information at hand, you can just all that an source grid into the interpolation subroutines, but even in the README, it states that one should use the grib2io.interpolate function.

So lets get this in then. Eventually grib2io and grib2io-interp will come back together anyways.

@EricEngle-NOAA EricEngle-NOAA merged commit 1028e92 into NOAA-MDL:main Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants