Remove inconsistencies in computation of air density with Thompson MP #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
thomp_nc_density
branch
from
71a9b6e
to
a1ca4a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update submodule pointer for fv3atm / ccpp-physics for the changes described in NOAA-GSL/ccpp-physics#79.
Issue(s) addressed
n/a
Testing
Regression testing against existing (EMC) baselines using Intel and GNU on Hera: As expected, all tests using Thompson MP failed with b4b differences (but all ran to completion), all other tests passed.
rt_hera_intel_against_existing.log
rt_hera_intel_against_existing_fail_test.log
rt_hera_gnu_against_existing.log
rt_hera_gnu_against_existing_fail_test.log
Regression testing using
rt_ccpp_dev.confwith Intel and GNU on Hera: create new baseline, then verify against it; all tests pass.rt_ccpp_dev_hera_intel_create.log
rt_ccpp_dev_hera_intel_verify.log
rt_ccpp_dev_hera_gnu_create.log
rt_ccpp_dev_hera_gnu_verify.log
Dependencies
NOAA-GSL/ccpp-physics#79
NOAA-GSL/fv3atm#74
#64