Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove shell workflow #380

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/exregional_run_ensgridvx.sh
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME
export NUM_ENS_MEMBERS
export NUM_PAD
export LOG_SUFFIX
Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_run_ensgridvx_mean.sh
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME
export INPUT_BASE
export LOG_SUFFIX

Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_run_ensgridvx_prob.sh
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME
export LOG_SUFFIX

#
Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_run_enspointvx.sh
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME
export NUM_ENS_MEMBERS

${METPLUS_PATH}/ush/run_metplus.py \
Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_run_enspointvx_mean.sh
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME

${METPLUS_PATH}/ush/run_metplus.py \
-c ${METPLUS_CONF}/common.conf \
Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_run_enspointvx_prob.sh
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME

${METPLUS_PATH}/ush/run_metplus.py \
-c ${METPLUS_CONF}/common.conf \
Expand Down
5 changes: 2 additions & 3 deletions scripts/exregional_run_fcst.sh
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,6 @@ if [ ${WRITE_DOPOST} = "TRUE" ]; then
yyyymmdd=${cdate:0:8}
hh=${cdate:8:2}
cyc=$hh
tmmark="tm00"
fmn="00"

if [ "${RUN_ENVIR}" = "nco" ]; then
Expand All @@ -539,15 +538,15 @@ if [ ${WRITE_DOPOST} = "TRUE" ]; then
post_mn=${post_time:10:2}
post_mn_or_null=""
post_fn_suffix="GrbF${fhr_d}"
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${tmmark}.grib2"
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${POST_OUTPUT_DOMAIN_NAME}.grib2"

basetime=$( $DATE_UTIL --date "$yyyymmdd $hh" +%y%j%H%M )
symlink_suffix="_${basetime}f${fhr}${post_mn}"
fids=( "prslev" "natlev" )
for fid in "${fids[@]}"; do
FID=$(echo_uppercase $fid)
post_orig_fn="${FID}.${post_fn_suffix}"
post_renamed_fn="${NET}.t${cyc}z.${fid}${post_renamed_fn_suffix}"
post_renamed_fn="${NET}.t${cyc}z.${fid}.${post_renamed_fn_suffix}"
mv_vrfy ${run_dir}/${post_orig_fn} ${post_renamed_fn}
ln_vrfy -fs ${post_renamed_fn} ${FID}${symlink_suffix}
done
Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_run_gridstatvx.sh
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME

#
#-----------------------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_run_pointstatvx.sh
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export METPLUS_CONF
export MET_CONFIG
export MODEL
export NET
export POST_OUTPUT_DOMAIN_NAME

${METPLUS_PATH}/ush/run_metplus.py \
-c ${METPLUS_CONF}/common.conf \
Expand Down
15 changes: 2 additions & 13 deletions scripts/exregional_run_post.sh
Original file line number Diff line number Diff line change
Expand Up @@ -172,17 +172,6 @@ cyc=$hh
#
#-----------------------------------------------------------------------
#
# The tmmark is a reference value used in real-time, DA-enabled NCEP models.
# It represents the delay between the onset of the DA cycle and the free
# forecast. With no DA in the SRW App at the moment, it is hard-wired to
# tm00 for now.
#
#-----------------------------------------------------------------------
#
tmmark="tm00"
#
#-----------------------------------------------------------------------
#
# Create the namelist file (itag) containing arguments to pass to the post-
# processor's executable.
#
Expand Down Expand Up @@ -300,7 +289,7 @@ if [ "${post_mn}" != "00" ]; then
fi

post_fn_suffix="GrbF${post_fhr}${dot_post_mn_or_null}"
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${tmmark}.grib2"
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${POST_OUTPUT_DOMAIN_NAME}.grib2"
#
# For convenience, change location to postprd_dir (where the final output
# from UPP will be located). Then loop through the two files that UPP
Expand All @@ -314,7 +303,7 @@ fids=( "prslev" "natlev" )
for fid in "${fids[@]}"; do
FID=$(echo_uppercase $fid)
post_orig_fn="${FID}.${post_fn_suffix}"
post_renamed_fn="${NET}.t${cyc}z.${fid}${post_renamed_fn_suffix}"
post_renamed_fn="${NET}.t${cyc}z.${fid}.${post_renamed_fn_suffix}"
mv_vrfy ${tmp_dir}/${post_orig_fn} ${post_renamed_fn}
create_symlink_to_file target="${post_renamed_fn}" \
symlink="${FID}${symlink_suffix}" \
Expand Down
2 changes: 1 addition & 1 deletion tests/WE2E/run_WE2E_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,7 @@ exist or is not a directory:
#
#-----------------------------------------------------------------------
#
$ushdir/generate_FV3LAM_wflow.sh || \
$ushdir/generate_FV3LAM_wflow.py || \
print_err_msg_exit "\
Could not generate an experiment for the test specified by test_name:
test_name = \"${test_name}\""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ LAYOUT_X="8"
LAYOUT_Y="12"
BLOCKSIZE="13"

POST_OUTPUT_DOMAIN_NAME="custom_ESGgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ LAYOUT_X="6"
LAYOUT_Y="6"
BLOCKSIZE="26"

POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ LAYOUT_X="6"
LAYOUT_Y="6"
BLOCKSIZE="26"

POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ LAYOUT_X="6"
LAYOUT_Y="6"
BLOCKSIZE="26"

POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
120 changes: 0 additions & 120 deletions ush/check_ruc_lsm.sh

This file was deleted.

24 changes: 18 additions & 6 deletions ush/config_defaults.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# This file sets the experiment's configuration variables (which are
# global shell variables) to their default values. For many of these
# variables, the valid values that they may take on are defined in the
# file $USHDIR/valid_param_vals.sh.
# file $USHDIR/valid_param_vals.py.
#
#-----------------------------------------------------------------------
#
Expand Down Expand Up @@ -45,7 +45,7 @@ RUN_ENVIR="nco"
# supported platform, and you want to use the Rocoto workflow manager,
# you will need set MACHINE="linux" and WORKFLOW_MANAGER="rocoto". This
# combination will assume a Slurm batch manager when generating the XML.
# Please see ush/valid_param_vals.sh for a full list of supported
# Please see ush/valid_param_vals.py for a full list of supported
# platforms.
#
# MACHINE_FILE:
Expand Down Expand Up @@ -411,6 +411,18 @@ WFLOW_LAUNCH_LOG_FN="log.launch_FV3LAM_wflow"
#
#-----------------------------------------------------------------------
#
# Set output file name. Definitions:
#
# POST_OUTPUT_DOMAIN_NAME:
# Domain name used in naming the output files of run_post by UPP or inline post.
# Output file name: $NET.tHHz.[var_name].f###.$POST_OUTPUT_DOMAIN_NAME.grib2
#
#-----------------------------------------------------------------------
#
POST_OUTPUT_DOMAIN_NAME=""
#
#-----------------------------------------------------------------------
#
# Set forecast parameters. Definitions:
#
# DATE_FIRST_CYCL:
Expand Down Expand Up @@ -612,7 +624,7 @@ NDAS_OBS_DIR=""
# conditions from the GFS started 6 hours earlier, then
# EXTRN_MDL_LBCS_OFFSET_HRS=6.
# Note: the default value is model-dependent and set in
# set_extrn_mdl_params.sh
# set_extrn_mdl_params.py
#
# FV3GFS_FILE_FMT_ICS:
# If using the FV3GFS model as the source of the ICs (i.e. if EXTRN_MDL_NAME_ICS
Expand Down Expand Up @@ -1009,7 +1021,7 @@ GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES=""
# in generating the files with 0-cell-, 3-cell-, and 4-cell-wide halos;
# they are not needed by the forecast model.
# NOTE: Probably don't need to make ESGgrid_WIDE_HALO_WIDTH a user-specified
# variable. Just set it in the function set_gridparams_ESGgrid.sh.
# variable. Just set it in the function set_gridparams_ESGgrid.py.
#
# Note that:
#
Expand Down Expand Up @@ -1169,7 +1181,7 @@ WRTCMP_dy=""
# commonly used set of grid-dependent parameters. The predefined grid
# parameters are specified in the script
#
# $HOMErrfs/ush/set_predef_grid_params.sh
# $HOMErrfs/ush/set_predef_grid_params.py
#
#-----------------------------------------------------------------------
#
Expand Down Expand Up @@ -1866,7 +1878,7 @@ SPP_TSCALE=( "21600.0" "21600.0" "21600.0" "21600.0" "21600.0" ) #Variable "spp_
SPP_SIGTOP1=( "0.1" "0.1" "0.1" "0.1" "0.1")
SPP_SIGTOP2=( "0.025" "0.025" "0.025" "0.025" "0.025" )
SPP_STDDEV_CUTOFF=( "1.5" "1.5" "2.5" "1.5" "1.5" )
ISEED_SPP=( "4" "4" "4" "4" "4" )
ISEED_SPP=( "4" "5" "6" "7" "8" )
#
#-----------------------------------------------------------------------
#
Expand Down
Loading