Added initialization of pores and resid

[tanyasmirnova]

Added GFS_Control_type arrays pores and resid for use in the stochastic perturbations of soil moisture (lndp_type=2). These arrays are initialized in set_soilveg with the Noah and Noah-MP LSMs and in set_soilveg_ruc with the RUC LSM.

Associated PRs:

NOAA-GSL/stochastic_physics#1
#71
NOAA-GSL/fv3atm#68 (contains NOAA-GSL/fv3atm#65)
NOAA-GSL/ufs-weather-model#57

See NOAA-GSL/ufs-weather-model#57 for regression testing.

[DomHeinzeller]

There is something missing in sfc_noahmp_drv.f (kind_phys not known):

[ 21%] Building Fortran object FV3/ccpp/physics/CMakeFiles/ccppphys.dir/physics/module_MYJPBL_wrapper.F90.o
cd /Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/tests/build_fv3/FV3/ccpp/physics && /usr/local/gnu_mpionly/bin/mpifort -DCCPP -DDEBUG -DFV3 -DINTERNAL_FILE_NML -DMACOSX -DMOIST_CAPPA -DMPI -DNEMS_GSM -DNETCDF -DOPENMP -DUSE_COND -I/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/tests/build_fv3/FV3/ccpp/framework/src -I/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/tests/build_fv3/FV3/ccpp/physics -I/usr/local/gnu_mpionly/hpc-stack-v1.1.0/include_d  -O0 -g -fPIC -fcray-pointer -ffree-line-length-none -fno-range-check -fbacktrace -cpp -fno-unsafe-math-optimizations -frounding-math -fsignaling-nans -ffpe-trap=invalid,zero,overflow -fcheck=bounds -fbacktrace -fno-range-check -fopenmp -I/usr/local/gnu_mpionly/hpc-stack-v1.1.0/include -L/usr/local/gnu_mpionly/hpc-stack-v1.1.0/lib -lnetcdff -lnetcdf -I/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/tests/build_fv3/FV3/ccpp/framework/src -fopenmp -ffree-line-length-none -O0 -g -fPIC    -fdefault-real-8 -fdefault-double-8  -c /Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/FV3/ccpp/physics/physics/module_MYJPBL_wrapper.F90 -o CMakeFiles/ccppphys.dir/physics/module_MYJPBL_wrapper.F90.o
/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/FV3/ccpp/physics/physics/sfc_noahmp_drv.f:37:28:

   37 |         real (kind=kind_phys), dimension(:), intent(out) :: pores, resid
      |                            1
Error: Symbol 'kind_phys' at (1) has no IMPLICIT type
/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/FV3/ccpp/physics/physics/sfc_noahmp_drv.f:27:64:

   27 |       subroutine noahmpdrv_init(me, isot, ivegsrc, nlunit, pores, resid,
      |                                                                1
Error: Symbol 'pores' at (1) has no IMPLICIT type
/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-gsl-develop-20201228-land-stochastic-perturbations/gnu/FV3/ccpp/physics/physics/sfc_noahmp_drv.f:27:71:

   27 |       subroutine noahmpdrv_init(me, isot, ivegsrc, nlunit, pores, resid,
      |                                                                       1
Error: Symbol 'resid' at (1) has no IMPLICIT type; did you mean 'refsmc'?
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccppphys.dir/physics/sfc_noahmp_drv.f.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [FV3/ccpp/physics/CMakeFiles/ccppphys.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Can you please make sure that your code compiles all suites successfully using the following command?

cd tests
./compile.sh hera.intel 'CCPP=Y DEBUG=Y' 2>&1 | tee compile.log

This compiles all suites and not just the ones you want to use (by adding SUITES=...). If none of the suites uses Noah MP, then those source files don't get compiled and the error doesn't get caught.