Combine all global sums in SIS_sum_output #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised SIS_sum_output.F90 to merge all blocking global sums in SIS2 that are used routinely into a single blocking sum in SIS_sum_output for improved model efficiency. Also removed unneeded variables from the SIS_sum_out_CS and reformatted the module use statements in this module. All answers are bitwise identical.
Revised SIS_sum_output.F90 to reproduce previous non-reproducing sums of total mass, salt and heat between hemispheres. These values do not alter solutions or SIS_parameter_doc files, but they were reported to stdout. Also provide array extents over which to do sums to reproducing_sum_EFP calls, avoiding working on zero values in halo points. All solutions are bitwise identical.
|
This has passed my internal Gaea regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised SIS_sum_output.F90 to merge all blocking global sums in SIS2 that are
used routinely into a single blocking sum in SIS_sum_output for improved model
efficiency. Also removed unneeded variables from the SIS_sum_out_CS and
reformatted the module use statements in this module. All answers are bitwise
identical.