Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflecting changes from move of basic_operations.py to NDSL #15

Merged
merged 1 commit into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/notebook/test_functionality.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
"metadata": {},
"outputs": [],
"source": [
"from pyFV3.stencils.basic_operations import copy_defn\n",
"from ndsl.stencils.basic_operations import copy_defn\n",
"\n",
"from_field = quantity_factory.ones(dims=(X_DIM, Y_DIM, Z_DIM), units=\"none\", dtype=\"float\")\n",
"to_field = quantity_factory.zeros(dims=(X_DIM, Y_DIM, Z_DIM), units=\"none\", dtype=\"float\")\n",
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/a2b_ord4.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from ndsl.constants import X_DIM, X_INTERFACE_DIM, Y_DIM, Y_INTERFACE_DIM, Z_DIM
from ndsl.dsl.typing import Float, FloatField, FloatFieldI, FloatFieldIJ
from ndsl.grid import GridData
from pyFV3.stencils.basic_operations import copy_defn
from ndsl.stencils.basic_operations import copy_defn


# comact 4-pt cubic interpolation
Expand Down
46 changes: 0 additions & 46 deletions pyFV3/stencils/basic_operations.py

This file was deleted.

2 changes: 1 addition & 1 deletion pyFV3/stencils/del2cubed.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from ndsl.dsl.stencil import get_stencils_with_varied_bounds
from ndsl.dsl.typing import Float, FloatField, FloatFieldIJ, cast_to_index3d
from ndsl.grid import DampingCoefficients
from pyFV3.stencils.basic_operations import copy_defn
from ndsl.stencils.basic_operations import copy_defn


#
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/divergence_damping.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
sqrt,
)

import ndsl.stencils.basic_operations as basic
import ndsl.stencils.corners as corners
import pyFV3.stencils.basic_operations as basic
from ndsl import Quantity, QuantityFactory, StencilFactory
from ndsl.constants import X_DIM, X_INTERFACE_DIM, Y_DIM, Y_INTERFACE_DIM, Z_DIM
from ndsl.dsl.dace.orchestration import dace_inhibitor, orchestrate
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/dyn_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
)

import ndsl.constants as constants
import pyFV3.stencils.basic_operations as basic
import ndsl.stencils.basic_operations as basic
import pyFV3.stencils.d_sw as d_sw
import pyFV3.stencils.nh_p_grad as nh_p_grad
import pyFV3.stencils.pe_halo as pe_halo
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/fv_dynamics.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
from ndsl.grid import DampingCoefficients, GridData
from ndsl.logging import ndsl_log
from ndsl.performance import NullTimer, Timer
from ndsl.stencils.basic_operations import copy_defn
from ndsl.stencils.c2l_ord import CubedToLatLon
from ndsl.typing import Checkpointer, Communicator
from pyFV3._config import DynamicalCoreConfig
from pyFV3.dycore_state import DycoreState
from pyFV3.stencils import fvtp2d, tracer_2d_1l
from pyFV3.stencils.basic_operations import copy_defn
from pyFV3.stencils.del2cubed import HyperdiffusionDamping
from pyFV3.stencils.dyn_core import AcousticDynamics
from pyFV3.stencils.neg_adj3 import AdjustNegativeTracerMixingRatio
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/fv_subgridz.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
ZVIR,
)
from ndsl.dsl.typing import Float, FloatField
from ndsl.stencils.basic_operations import dim
from pyFV3.dycore_state import DycoreState
from pyFV3.stencils.basic_operations import dim


RK = CP_AIR / RDGAS + 1.0
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/map_single.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from ndsl import QuantityFactory, StencilFactory, orchestrate
from ndsl.constants import X_DIM, Y_DIM, Z_DIM
from ndsl.dsl.typing import Float, FloatField, FloatFieldIJ, IntFieldIJ # noqa: F401
from pyFV3.stencils.basic_operations import copy_defn
from ndsl.stencils.basic_operations import copy_defn
from pyFV3.stencils.remap_profile import RemapProfile


Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/remapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
Z_INTERFACE_DIM,
)
from ndsl.dsl.typing import Float, FloatField, FloatFieldIJ, FloatFieldK
from ndsl.stencils.basic_operations import adjust_divide_stencil
from ndsl.typing import Checkpointer
from pyFV3._config import RemappingConfig
from pyFV3.stencils import moist_cv
from pyFV3.stencils.basic_operations import adjust_divide_stencil
from pyFV3.stencils.map_single import MapSingle
from pyFV3.stencils.mapn_tracer import MapNTracer
from pyFV3.stencils.moist_cv import moist_pt_func, moist_pt_last_step
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/saturation_adjustment.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
import ndsl.constants as constants
from ndsl import StencilFactory
from ndsl.dsl.typing import Float, FloatField, FloatFieldIJ
from ndsl.stencils.basic_operations import dim
from pyFV3._config import SatAdjustConfig
from pyFV3.stencils.basic_operations import dim
from pyFV3.stencils.moist_cv import compute_pkz_func


Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/temperature_adjust.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import ndsl.constants as constants
from ndsl.dsl.typing import Float, FloatField
from pyFV3.stencils.basic_operations import sign
from ndsl.stencils.basic_operations import sign


def apply_diffusive_heating(
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/xppm.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

from ndsl import StencilFactory
from ndsl.dsl.typing import FloatField, FloatFieldIJ, Index3D
from ndsl.stencils.basic_operations import sign
from pyFV3.stencils import ppm
from pyFV3.stencils.basic_operations import sign


@gtscript.function
Expand Down
2 changes: 1 addition & 1 deletion pyFV3/stencils/yppm.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

from ndsl import StencilFactory, orchestrate
from ndsl.dsl.typing import FloatField, FloatFieldIJ, Index3D
from ndsl.stencils.basic_operations import sign
from pyFV3.stencils import ppm
from pyFV3.stencils.basic_operations import sign


@gtscript.function
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
]

test_requirements = ["pytest", "pytest-subtests", "serialbox"]
ndsl_requirements = ["ndsl @ git+https://github.com/NOAA-GFDL/NDSL.git@2024.03.01"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why we would need a release out of main of pyFV3 so we can have a version that does not depend on the develop branch

ndsl_requirements = ["ndsl @ git+https://github.com/NOAA-GFDL/NDSL.git@develop"]
develop_requirements = test_requirements + ndsl_requirements + ["pre-commit"]

extras_requires = {
Expand Down
Loading