Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in print statement (FORWARD example) #62

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

romanc
Copy link
Collaborator

@romanc romanc commented Aug 2, 2024

Description

The sample code for showcasing FORWARD computation (in the K axis) calls mult_upward with origin=(nhalo,nhalo,1). The print statement differs in the z-value and shows origin=(nhalo,nhalo,0). This can be confusing for developers which just skim the output and don't read the code that is actually executed. The subsequent white-space change is only for consistency.

How Has This Been Tested?

I ran this notebook locally.

Checklist:

  • My code follows the style guidelines of this project
    @FlorianDeconinck isn't there automatic linting for PRs?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

The sample code for showcasing FORWARD computation (in the K axis) calls
`mult_upward` with `origin=(nhalo,nhalo,1)`. The print statement differs
in the z-value and shows `origin=(nhalo,nhalo,0)`. This can be confusing
for developers which just skim the output and don't read the code that
is actually executed.
@FlorianDeconinck
Copy link
Collaborator

CI has lint via pre-commit indeed

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit 7679ff0 into develop Aug 5, 2024
5 checks passed
@FlorianDeconinck FlorianDeconinck deleted the fix/typo-in-gt4py-basic-example branch August 5, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants