Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the mysign symbol missing bug in python 3.11 #60

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

xyuan
Copy link
Collaborator

@xyuan xyuan commented Jul 30, 2024

Description
This PR fix the python 3.11 runtime bugs caused by the node visitor transverse depth limitation, it crashed as missing symbol error during runtime.

This is caused by the optimization pass for oir and dace sdfg, which removes the "unused" symbol, because the limitation of node visitor transver depth limitation. This issue appeared in the dace backend with and without orchestration option.

Fixes # (issue)

How Has This Been Tested?
This fix has been tested on AMD box using dace backend with and without orchestration option using CPUs.

Checklist:

  • [ y ] My code follows the style guidelines of this project
  • [ y ] I have performed a self-review of my own code
  • [ y ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ y ] My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@xyuan xyuan changed the title fix the mysign symbol bug in python 3.11 fix the mysign symbol missing bug in python 3.11 Jul 30, 2024
@xyuan
Copy link
Collaborator Author

xyuan commented Jul 30, 2024

here is the test output using dace backend and layout 2x2 with orchestration on CPU using 24 mpi ranks

2024-07-29 20:55:58|INFO|rank 19|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 17|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 18|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 23|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 21|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 22|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 23|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 21|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 22|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 3|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 1|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 2|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 1|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 3|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 2|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 4|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 4|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 16|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 16|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 20|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 0|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished
2024-07-29 20:55:58|INFO|rank 20|ndsl.logging:cleaning up driver
2024-07-29 20:55:58|INFO|rank 0|ndsl.logging:cleaning up driver

@xyuan xyuan requested a review from oelbert July 30, 2024 13:15
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix to an unfortunate problem

@fmalatino fmalatino merged commit 3b73345 into NOAA-GFDL:develop Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants