Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2024.04.00 #35

Merged
merged 18 commits into from
Apr 17, 2024
Merged

Release 2024.04.00 #35

merged 18 commits into from
Apr 17, 2024

Conversation

fmalatino
Copy link
Contributor

Description
Release of NDSL 2024.04.00

How Has This Been Tested?

  • Unit tests in pyFV3 and pySHiELD

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

fmalatino and others added 17 commits March 6, 2024 15:48
@fmalatino
Added basic_operations.py from pyFV3 to ndsl/stencils
17d17fb
@fmalatino
Merge branch 'develop' into feature/stencil_basic_ops
4e7a232
@fmalatino
Merge branch 'develop' into feature/stencil_basic_ops
f384ccb
@fmalatino
Added rough draft of unit tests
9f9e25c
@fmalatino
Merge branch 'develop' into feature/stencil_basic_ops
ca5292c
@fmalatino
Updated unit test
a15accc
@fmalatino
Linting
330e52d
@fmalatino
Updated docstrings of basic_operations and using Quantity instead of …
5e4daf4 
…gtstorage for testing
@fmalatino
Updated logic of unit tests in test_basic_operations.py
7f0d0f0
@fmalatino
Using .all() instead of .any()
b086542
@FlorianDeconinck
Merge pull request #21 from NOAA-GFDL/feature/stencil_basic_ops
85c2213 
Added basic_operations.py from pyFV3/stencils to ndsl/stencils
@FlorianDeconinck
Allow pressure coeff to be read from ak & bk data
3bf2a48
@FlorianDeconinck
Freezing mpi4py to 3.1.6
759c852
@FlorianDeconinck
Merge pull request #34 from NOAA-GFDL/feature/eta_from_data
3ab2cff 
Allow pressure coeff to be read from ak & bk data
@fmalatino
Merge branch 'main' into develop
3bc15b9
@fmalatino
Added reference to RC in setup.py
6a8b674
@FlorianDeconinck
Revert public API changes done in PR34
044155b
@FlorianDeconinck
Copy link
Collaborator

Hold for #36 which fixes bad private API swap I did in #34

@fmalatino
Merge pull request #36 from NOAA-GFDL/fix/fix_public_ETA_fn
61c4cbe 
Revert public API changes done in PR34
FlorianDeconinck
FlorianDeconinck approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit bf23761 into main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmalatino @FlorianDeconinck