Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DaCe to top of master as of March 1st. #19

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Mar 1, 2024

Description
DaCe team fixed the dace:cpu compilation issue we were having by removing the double const on read pointers at code generation (which was tripping gcc).

The new version comes with a lot of fixes to merging transform we might take advantage off. No tests have been done on those.

How Has This Been Tested?
Ran validation on FVDynamics for dace:cpu and dace:gpu orchestrated.
No performance benchmark.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@fmalatino fmalatino self-requested a review March 5, 2024 14:58
@fmalatino fmalatino merged commit 52836a9 into develop Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants