Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add residual loss term for internal tides #95

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

raphaeldussin
Copy link

this term uses the residual from the reflection/transmission coefficients to compute the energy loss due to scattering to higher modes on the slopes. Replacement for PR #33 with clean history

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #95 (8852a28) into dev/gfdl (eae86d6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           dev/gfdl      #95      +/-   ##
============================================
- Coverage     28.99%   28.98%   -0.02%     
============================================
  Files           246      246              
  Lines         72304    72348      +44     
============================================
  Hits          20967    20967              
- Misses        51337    51381      +44     
Impacted Files Coverage Δ
...c/parameterizations/lateral/MOM_internal_tides.F90 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae86d6...8852a28. Read the comment docs.

@marshallward
Copy link
Member

marshallward commented Mar 28, 2022

Just a reminder that this has outstanding commits conflicts.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15104 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants