Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set truncation file handle check from < 0 to == -1 #739

Open
wants to merge 1 commit into
base: dev/gfdl
Choose a base branch
from
Open

Set truncation file handle check from < 0 to == -1 #739

wants to merge 1 commit into from

Commits on Oct 11, 2024

  1. Set truncation file handle check from < 0 to == -1 

    This patch replaces the `CS%[uv]_file < 0` checks with
`CS%[uv]_file == -1`.  FMS1 returns negative file handles for missing or
otherwise error-prone files, but the FMS2 IO framework relies on
`newunit=` to autogenerate handle IDs, which are always negative and
cannot be used with checks for negative values.

The check is replaced with equality with -1.  `newunit` is guaranteed to
never return -1 for a valid file, so this is a valid check for a missing
file.  It also lets us continue to use -1 as the initial (unopened)
value.

Behavior is compatible with `mpp_open()` output, so this can also be
used with the FMS1 API.

A better solution would be to introduce some validation function which
is defined by each API, but there is not yet any need for such
sophistication.
    @marshallward
    marshallward committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    68701fd View commit details
    Browse the repository at this point in the history