forked from mom-ocean/MOM6
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOM6:(*)+Reproducing tracer stocks #73
Merged
marshallward
merged 6 commits into
NOAA-GFDL:dev/gfdl
from
Hallberg-NOAA:reproducing_tracer_stocks
Feb 26, 2022
Merged
MOM6:(*)+Reproducing tracer stocks #73
marshallward
merged 6 commits into
NOAA-GFDL:dev/gfdl
from
Hallberg-NOAA:reproducing_tracer_stocks
Feb 26, 2022
Commits on Feb 21, 2022
-
Report mean temperature from MOM_state_stats()
Actually calculate the mean temperature and salinity reported by MOM_state_stats(). Due to an oversight, these means were always being reported as 0. This changes the output when the debugging flag DEBUG_CONSERVATION=True. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for 8e2e73e - Browse repository at this point
Copy the full SHA 8e2e73eView commit details -
Added the new function global_mass_int_EFP(), which is analogous to global_mass_integral but returns its result in extended fixed point (EFP_type) format and always uses reproducing sums, to facilitate layout-invariant global integrals but with the potential for deferred global reductions so that this last step can be combined for various global reductions for efficiency. All answers are bitwise identical, but there is a new public interface.
Configuration menu - View commit details
-
Copy full SHA for 4dc1fd3 - Browse repository at this point
Copy the full SHA 4dc1fd3View commit details -
Use global_mass_integral in lateral_bdry_diff
Use global_mass_integral for the debugging diagnostics of the tracer amounts before and after diffusion in lateral_boundary_diffusion, and replaced a call to write(*,*) with a call to MOM_mesg to actually write the message. The global_mass_integral uses reproducing sums, and is invariant to layout, while MOM_mesg is preferable for output because it will allow us to more cleanly control how output is handled and which processors do the writing. All solutions are bitwise identical, although some debugging output will change.
Configuration menu - View commit details
-
Copy full SHA for 656a372 - Browse repository at this point
Copy the full SHA 656a372View commit details -
Use reproducing sums for tabulating tracer stocks, and move the global sum for the tracer stocks form write_energy into call_tracer_stocks. This involves changes to the type of an argument (from real to EFP_type) for two arguments to the internal routine store_stocks. Existing tracer stock packages will still work, but to benefit from the reproducing sums, they will also have to change their reported values from real to EFP_type. This is demonstrated for two packages (advection_test_tracer and ideal_age_example), where the stocks are now found with calls to global_mass_int_EFP(), replacing the previous explicit sums. With this change, the reported stock values from these packages are identical for different PE layouts and can be much more accurate than before, but they are different from the previously reported values at roundoff (for positive-definite tracers), but it could be larger for tracers with a near-zero mean value. All solutions are bitwise identical, but output changes.
Configuration menu - View commit details
-
Copy full SHA for 9b2debd - Browse repository at this point
Copy the full SHA 9b2debdView commit details -
(*)+Use reproducing stocks for all tracer packages
Modified the remaining tracer packages to use the reproducing stocks. The reported stock values from these packages will have changed slightly, but they now reproduce across PE layouts. All solutions are bitwise identical, but output changes.
Configuration menu - View commit details
-
Copy full SHA for f996d09 - Browse repository at this point
Copy the full SHA f996d09View commit details
Commits on Feb 23, 2022
-
Removed trailing white space on two lines. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for 418bc66 - Browse repository at this point
Copy the full SHA 418bc66View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.