Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the descriptions of 60 variables #7

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

Hallberg-NOAA
Copy link
Member

Corrected the units or made other clarifications in comments describing 60
variables in 28 files. In addition three unused (and unscaled) variables were
eliminated. All answers and output are bitwise identical.

Hallberg-NOAA and others added 2 commits November 22, 2021 20:05
  Corrected the units or made other clarifications in comments describing 60
variables in 28 files.  In addition three unused (and unscaled) variables were
eliminated.  All answers and output are bitwise identical.
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #7 (d8abf05) into dev/gfdl (6608730) will increase coverage by 0.00%.
The diff coverage is 36.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl       #7   +/-   ##
=========================================
  Coverage     29.18%   29.18%           
=========================================
  Files           239      239           
  Lines         71280    71280           
=========================================
+ Hits          20805    20806    +1     
+ Misses        50475    50474    -1     
Impacted Files Coverage Δ
src/ALE/MOM_regridding.F90 21.45% <0.00%> (ø)
src/core/MOM_barotropic.F90 37.50% <ø> (ø)
src/core/MOM_density_integrals.F90 9.39% <0.00%> (ø)
src/core/MOM_variables.F90 28.57% <ø> (ø)
src/diagnostics/MOM_diagnostics.F90 75.64% <ø> (ø)
src/diagnostics/MOM_wave_speed.F90 23.97% <ø> (ø)
src/initialization/MOM_fixed_initialization.F90 61.97% <ø> (ø)
src/initialization/MOM_shared_initialization.F90 28.64% <ø> (ø)
src/initialization/MOM_state_initialization.F90 20.73% <0.00%> (ø)
src/parameterizations/lateral/MOM_MEKE.F90 50.88% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6608730...d8abf05. Read the comment docs.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14200 ✔️

@marshallward marshallward merged commit 4a7ab45 into NOAA-GFDL:dev/gfdl Nov 26, 2021
@Hallberg-NOAA Hallberg-NOAA deleted the more_unit_fixes branch November 27, 2021 22:54
@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Feb 1, 2022
theresa-morrison pushed a commit to theresa-morrison/MOM6 that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants