Mixed Mode Updates needed for FMS 2022.01 #66
Conversation
There was a problem hiding this comment.
These changes were discussed at a recent MOM6 dev call, with the team at EMC presenting them. As written, these changes would require an immediate change to the version of FMS that people are using, with no possibility of doing any kind of comparison across the change where we mix old and new versions of FMS and MOM6. We have gone through something like this before, and there was widespread agreement that this would be unacceptably disruptive and error prone.
Instead we have an alternative solution that will not be disruptive for the broad community of MOM6 users. The entire config_src/infra/FMS2 directory should be duplicated into a new directory (the name that was floated was config_src/infra/FMS2_mp, for "mixed precision"). The contents of that new directory could then be modified to permit the use of the new version of FMS, and existing MOM6 users could migrate over to this new version in an orderly way as their other workloads and run production schedules permit.
|
Thank you for that feedback. I will wait for the team at EMC to address your remarks on their PR (79). |
| @@ -276,15 +294,15 @@ end function send_data_infra_1d | |||
| logical function send_data_infra_2d(diag_field_id, field, is_in, ie_in, js_in, je_in, & | |||
| time, mask, rmask, weight, err_msg) | |||
| integer, intent(in) :: diag_field_id !< The diagnostic manager identifier for this field | |||
| real, dimension(:,:), intent(in) :: field !< A 2-d array of values being recorded | |||
| class(*),dimension(:,:), intent(in) :: field !< A 2-d array of values being recorded | |||
There was a problem hiding this comment.
Why is this needed? And if it is required, why is it not also needed in the caller of this routine?
FMS 2022.01 will enable mixed mode updates that are needed for the ufs-weather-model. This PR brings the work done by MInsuk Ji in the NOAA-EMC PR 79 (NOAA-EMC#79) and brings it to dev/gfdl branch which is needed for the GFDL models to work with FMS 2022.01.
I am also requesting a tag be created following this PR's merge for use with the GFDL models (the tag could be "2022.01" or something else if you prefer).